From: Kevin Hilman <khilman@ti.com>
To: Tarun Kanti DebBarma <tarun.kanti@ti.com>
Cc: linux-omap@vger.kernel.org, santosh.shilimkar@ti.com, tony@atomide.com
Subject: Re: [PATCH v2 18/18] GPIO: OMAP2+: Clean prepare_for_idle and resume_after_idle
Date: Thu, 16 Jun 2011 11:10:10 -0700 [thread overview]
Message-ID: <87ips5lkal.fsf@ti.com> (raw)
In-Reply-To: <1308111806-29152-9-git-send-email-tarun.kanti@ti.com> (Tarun Kanti DebBarma's message of "Wed, 15 Jun 2011 09:53:26 +0530")
Tarun Kanti DebBarma <tarun.kanti@ti.com> writes:
> Simplify omap2_gpio_prepare_for_idle() and omap2_gpio_resume_after_idle()
> by moving most of the stuff to *_pm_runtime_suspend() and *_pm_runtime_resume().
> Also, omap_gpio_suspend() and omap_gpio_resume() optimized to operate per
> GPIO bank instead of operating on entire list every time.
This second part should be a separate patch.
> Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@ti.com>
> Signed-off-by: Charulatha V <charu@ti.com>
[...]
>
> +#ifdef CONFIG_ARCH_OMAP2PLUS
> +static void omap_gpio_save_context(struct gpio_bank *bank);
> +static void omap_gpio_restore_context(struct gpio_bank *bank);
> +#endif
> +
> static int omap_gpio_pm_runtime_suspend(struct device *dev)
> {
> +#ifdef CONFIG_ARCH_OMAP2PLUS
c.f. #ifdefs are ugly in Documentation/SubmittingPatches
Just wrap all of these funcions: runtime PM, save/restore context,
prepare/resume from idle inside the #ifdef. Then have an else
clause with NULL versions of the runtime PM functions.
Kevin
next prev parent reply other threads:[~2011-06-16 18:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-15 4:23 [PATCH v2 10/18] GPIO: OMAP: Remove hardcoded offsets in ctxt save/restore Tarun Kanti DebBarma
2011-06-15 4:23 ` [PATCH v2 11/18] GPIO: OMAP: Clean set_gpio_triggering function Tarun Kanti DebBarma
2011-06-16 17:40 ` Kevin Hilman
2011-06-17 5:16 ` DebBarma, Tarun Kanti
2011-06-15 4:23 ` [PATCH v2 12/18] GPIO: OMAP: Clean omap_gpio_mod_init function Tarun Kanti DebBarma
2011-06-16 17:49 ` Kevin Hilman
2011-06-17 5:11 ` DebBarma, Tarun Kanti
2011-06-27 10:48 ` DebBarma, Tarun Kanti
2011-06-27 23:06 ` Kevin Hilman
2011-06-15 4:23 ` [PATCH v2 13/18] GPIO: OMAP15xx: Use pinctrl offset instead of macro Tarun Kanti DebBarma
2011-06-15 4:23 ` [PATCH v2 14/18] GPIO: OMAP: Fix use of readl/readw to access isr_reg Tarun Kanti DebBarma
2011-06-16 17:53 ` Kevin Hilman
2011-06-17 5:07 ` DebBarma, Tarun Kanti
2011-06-16 17:57 ` Kevin Hilman
2011-06-17 5:05 ` DebBarma, Tarun Kanti
2011-06-15 4:23 ` [PATCH v2 15/18] GPIO: OMAP: Remove bank->method & METHOD_* macros Tarun Kanti DebBarma
2011-06-15 4:23 ` [PATCH v2 16/18] GPIO: OMAP: Fix bankwidth for OMAP7xx MPUIO Tarun Kanti DebBarma
2011-06-15 4:23 ` [PATCH v2 17/18] GPIO: OMAP: Use PM runtime framework Tarun Kanti DebBarma
2011-06-16 18:03 ` Kevin Hilman
2011-06-17 5:00 ` DebBarma, Tarun Kanti
2011-06-15 4:23 ` [PATCH v2 18/18] GPIO: OMAP2+: Clean prepare_for_idle and resume_after_idle Tarun Kanti DebBarma
2011-06-16 18:10 ` Kevin Hilman [this message]
2011-06-17 4:57 ` DebBarma, Tarun Kanti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ips5lkal.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=tarun.kanti@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox