* [PATCH] omap: dmtimer: Enable autoidle
@ 2011-02-14 17:26 Tero Kristo
2011-02-14 23:28 ` Kevin Hilman
0 siblings, 1 reply; 10+ messages in thread
From: Tero Kristo @ 2011-02-14 17:26 UTC (permalink / raw)
To: linux-omap
This will save some power.
Signed-off-by: Tero Kristo <tero.kristo@nokia.com>
---
arch/arm/plat-omap/dmtimer.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-omap/dmtimer.c
index 1d706cf..949becc 100644
--- a/arch/arm/plat-omap/dmtimer.c
+++ b/arch/arm/plat-omap/dmtimer.c
@@ -341,6 +341,7 @@ static void omap_dm_timer_reset(struct omap_dm_timer *timer)
l = omap_dm_timer_read_reg(timer, OMAP_TIMER_OCP_CFG_REG);
l |= 0x02 << 3; /* Set to smart-idle mode */
l |= 0x2 << 8; /* Set clock activity to perserve f-clock on idle */
+ l |= 0x1 << 0; /* Set autoidle */
/*
* Enable wake-up on OMAP2 CPUs.
--
1.7.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] omap: dmtimer: Enable autoidle
2011-02-14 17:26 [PATCH] omap: dmtimer: Enable autoidle Tero Kristo
@ 2011-02-14 23:28 ` Kevin Hilman
2011-02-15 8:16 ` Tero.Kristo
0 siblings, 1 reply; 10+ messages in thread
From: Kevin Hilman @ 2011-02-14 23:28 UTC (permalink / raw)
To: Tero Kristo; +Cc: linux-omap
Tero Kristo <tero.kristo@nokia.com> writes:
> This will save some power.
>
> Signed-off-by: Tero Kristo <tero.kristo@nokia.com>
Please report which platforms this was tested with.
Also, please Cc linux-arm-kernel.
Thanks,
Kevin
> ---
> arch/arm/plat-omap/dmtimer.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-omap/dmtimer.c
> index 1d706cf..949becc 100644
> --- a/arch/arm/plat-omap/dmtimer.c
> +++ b/arch/arm/plat-omap/dmtimer.c
> @@ -341,6 +341,7 @@ static void omap_dm_timer_reset(struct omap_dm_timer *timer)
> l = omap_dm_timer_read_reg(timer, OMAP_TIMER_OCP_CFG_REG);
> l |= 0x02 << 3; /* Set to smart-idle mode */
> l |= 0x2 << 8; /* Set clock activity to perserve f-clock on idle */
> + l |= 0x1 << 0; /* Set autoidle */
>
> /*
> * Enable wake-up on OMAP2 CPUs.
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] omap: dmtimer: Enable autoidle
2011-02-14 23:28 ` Kevin Hilman
@ 2011-02-15 8:16 ` Tero.Kristo
2011-02-15 9:20 ` DebBarma, Tarun Kanti
0 siblings, 1 reply; 10+ messages in thread
From: Tero.Kristo @ 2011-02-15 8:16 UTC (permalink / raw)
To: khilman; +Cc: linux-omap
>-----Original Message-----
>From: ext Kevin Hilman [mailto:khilman@ti.com]
>Sent: 15 February, 2011 01:29
>To: Kristo Tero (Nokia-MS/Tampere)
>Cc: linux-omap@vger.kernel.org
>Subject: Re: [PATCH] omap: dmtimer: Enable autoidle
>
>Tero Kristo <tero.kristo@nokia.com> writes:
>
>> This will save some power.
>>
>> Signed-off-by: Tero Kristo <tero.kristo@nokia.com>
>
>Please report which platforms this was tested with.
Tested only on OMAP3.
Should this be changed to apply only on that one? I don't know about OMAP4, but I think this should work on OMAP2 at least based on spec.
>
>Also, please Cc linux-arm-kernel.
>
>Thanks,
>
>Kevin
>
>> ---
>> arch/arm/plat-omap/dmtimer.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-
>omap/dmtimer.c
>> index 1d706cf..949becc 100644
>> --- a/arch/arm/plat-omap/dmtimer.c
>> +++ b/arch/arm/plat-omap/dmtimer.c
>> @@ -341,6 +341,7 @@ static void omap_dm_timer_reset(struct
>omap_dm_timer *timer)
>> l = omap_dm_timer_read_reg(timer, OMAP_TIMER_OCP_CFG_REG);
>> l |= 0x02 << 3; /* Set to smart-idle mode */
>> l |= 0x2 << 8; /* Set clock activity to perserve f-clock on idle
>*/
>> + l |= 0x1 << 0; /* Set autoidle */
>>
>> /*
>> * Enable wake-up on OMAP2 CPUs.
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] omap: dmtimer: Enable autoidle
2011-02-15 8:16 ` Tero.Kristo
@ 2011-02-15 9:20 ` DebBarma, Tarun Kanti
2011-02-15 9:31 ` DebBarma, Tarun Kanti
0 siblings, 1 reply; 10+ messages in thread
From: DebBarma, Tarun Kanti @ 2011-02-15 9:20 UTC (permalink / raw)
To: Tero.Kristo@nokia.com, Hilman, Kevin; +Cc: linux-omap@vger.kernel.org
> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> owner@vger.kernel.org] On Behalf Of Tero.Kristo@nokia.com
> Sent: Tuesday, February 15, 2011 1:47 PM
> To: Hilman, Kevin
> Cc: linux-omap@vger.kernel.org
> Subject: RE: [PATCH] omap: dmtimer: Enable autoidle
>
>
>
> >-----Original Message-----
> >From: ext Kevin Hilman [mailto:khilman@ti.com]
> >Sent: 15 February, 2011 01:29
> >To: Kristo Tero (Nokia-MS/Tampere)
> >Cc: linux-omap@vger.kernel.org
> >Subject: Re: [PATCH] omap: dmtimer: Enable autoidle
> >
> >Tero Kristo <tero.kristo@nokia.com> writes:
> >
> >> This will save some power.
> >>
> >> Signed-off-by: Tero Kristo <tero.kristo@nokia.com>
> >
> >Please report which platforms this was tested with.
>
> Tested only on OMAP3.
>
> Should this be changed to apply only on that one? I don't know about
> OMAP4, but I think this should work on OMAP2 at least based on spec.
It works on OMAP2 and OMAP4.
--
Tarun
>
>
> >
> >Also, please Cc linux-arm-kernel.
> >
> >Thanks,
> >
> >Kevin
> >
> >> ---
> >> arch/arm/plat-omap/dmtimer.c | 1 +
> >> 1 files changed, 1 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-
> >omap/dmtimer.c
> >> index 1d706cf..949becc 100644
> >> --- a/arch/arm/plat-omap/dmtimer.c
> >> +++ b/arch/arm/plat-omap/dmtimer.c
> >> @@ -341,6 +341,7 @@ static void omap_dm_timer_reset(struct
> >omap_dm_timer *timer)
> >> l = omap_dm_timer_read_reg(timer, OMAP_TIMER_OCP_CFG_REG);
> >> l |= 0x02 << 3; /* Set to smart-idle mode */
> >> l |= 0x2 << 8; /* Set clock activity to perserve f-clock on idle
> >*/
> >> + l |= 0x1 << 0; /* Set autoidle */
> >>
> >> /*
> >> * Enable wake-up on OMAP2 CPUs.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] omap: dmtimer: Enable autoidle
2011-02-15 9:20 ` DebBarma, Tarun Kanti
@ 2011-02-15 9:31 ` DebBarma, Tarun Kanti
2011-02-15 9:45 ` Tero.Kristo
0 siblings, 1 reply; 10+ messages in thread
From: DebBarma, Tarun Kanti @ 2011-02-15 9:31 UTC (permalink / raw)
To: Tero.Kristo@nokia.com, Hilman, Kevin; +Cc: linux-omap@vger.kernel.org
> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> owner@vger.kernel.org] On Behalf Of DebBarma, Tarun Kanti
> Sent: Tuesday, February 15, 2011 2:50 PM
> To: Tero.Kristo@nokia.com; Hilman, Kevin
> Cc: linux-omap@vger.kernel.org
> Subject: RE: [PATCH] omap: dmtimer: Enable autoidle
>
> > -----Original Message-----
> > From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> > owner@vger.kernel.org] On Behalf Of Tero.Kristo@nokia.com
> > Sent: Tuesday, February 15, 2011 1:47 PM
> > To: Hilman, Kevin
> > Cc: linux-omap@vger.kernel.org
> > Subject: RE: [PATCH] omap: dmtimer: Enable autoidle
> >
> >
> >
> > >-----Original Message-----
> > >From: ext Kevin Hilman [mailto:khilman@ti.com]
> > >Sent: 15 February, 2011 01:29
> > >To: Kristo Tero (Nokia-MS/Tampere)
> > >Cc: linux-omap@vger.kernel.org
> > >Subject: Re: [PATCH] omap: dmtimer: Enable autoidle
> > >
> > >Tero Kristo <tero.kristo@nokia.com> writes:
> > >
> > >> This will save some power.
> > >>
> > >> Signed-off-by: Tero Kristo <tero.kristo@nokia.com>
> > >
> > >Please report which platforms this was tested with.
> >
> > Tested only on OMAP3.
> >
> > Should this be changed to apply only on that one? I don't know about
> > OMAP4, but I think this should work on OMAP2 at least based on spec.
> It works on OMAP2 and OMAP4.
Ok, on OMAP4 I should have clarified further.
AUTOIDLE is present only for millisecond timers: 1,2,10.
The reset of the timers do not have this bit.
--
Tarun
>
> >
> >
> > >
> > >Also, please Cc linux-arm-kernel.
> > >
> > >Thanks,
> > >
> > >Kevin
> > >
> > >> ---
> > >> arch/arm/plat-omap/dmtimer.c | 1 +
> > >> 1 files changed, 1 insertions(+), 0 deletions(-)
> > >>
> > >> diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-
> > >omap/dmtimer.c
> > >> index 1d706cf..949becc 100644
> > >> --- a/arch/arm/plat-omap/dmtimer.c
> > >> +++ b/arch/arm/plat-omap/dmtimer.c
> > >> @@ -341,6 +341,7 @@ static void omap_dm_timer_reset(struct
> > >omap_dm_timer *timer)
> > >> l = omap_dm_timer_read_reg(timer, OMAP_TIMER_OCP_CFG_REG);
> > >> l |= 0x02 << 3; /* Set to smart-idle mode */
> > >> l |= 0x2 << 8; /* Set clock activity to perserve f-clock on
> idle
> > >*/
> > >> + l |= 0x1 << 0; /* Set autoidle */
> > >>
> > >> /*
> > >> * Enable wake-up on OMAP2 CPUs.
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] omap: dmtimer: Enable autoidle
2011-02-15 9:31 ` DebBarma, Tarun Kanti
@ 2011-02-15 9:45 ` Tero.Kristo
2011-02-15 9:51 ` DebBarma, Tarun Kanti
0 siblings, 1 reply; 10+ messages in thread
From: Tero.Kristo @ 2011-02-15 9:45 UTC (permalink / raw)
To: tarun.kanti, khilman; +Cc: linux-omap
>-----Original Message-----
>From: ext DebBarma, Tarun Kanti [mailto:tarun.kanti@ti.com]
>Sent: 15 February, 2011 11:31
>To: Kristo Tero (Nokia-MS/Tampere); Hilman, Kevin
>Cc: linux-omap@vger.kernel.org
>Subject: RE: [PATCH] omap: dmtimer: Enable autoidle
>
>> -----Original Message-----
>> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
>> owner@vger.kernel.org] On Behalf Of DebBarma, Tarun Kanti
>> Sent: Tuesday, February 15, 2011 2:50 PM
>> To: Tero.Kristo@nokia.com; Hilman, Kevin
>> Cc: linux-omap@vger.kernel.org
>> Subject: RE: [PATCH] omap: dmtimer: Enable autoidle
>>
>> > -----Original Message-----
>> > From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
>> > owner@vger.kernel.org] On Behalf Of Tero.Kristo@nokia.com
>> > Sent: Tuesday, February 15, 2011 1:47 PM
>> > To: Hilman, Kevin
>> > Cc: linux-omap@vger.kernel.org
>> > Subject: RE: [PATCH] omap: dmtimer: Enable autoidle
>> >
>> >
>> >
>> > >-----Original Message-----
>> > >From: ext Kevin Hilman [mailto:khilman@ti.com]
>> > >Sent: 15 February, 2011 01:29
>> > >To: Kristo Tero (Nokia-MS/Tampere)
>> > >Cc: linux-omap@vger.kernel.org
>> > >Subject: Re: [PATCH] omap: dmtimer: Enable autoidle
>> > >
>> > >Tero Kristo <tero.kristo@nokia.com> writes:
>> > >
>> > >> This will save some power.
>> > >>
>> > >> Signed-off-by: Tero Kristo <tero.kristo@nokia.com>
>> > >
>> > >Please report which platforms this was tested with.
>> >
>> > Tested only on OMAP3.
>> >
>> > Should this be changed to apply only on that one? I don't know about
>> > OMAP4, but I think this should work on OMAP2 at least based on spec.
>> It works on OMAP2 and OMAP4.
>Ok, on OMAP4 I should have clarified further.
>AUTOIDLE is present only for millisecond timers: 1,2,10.
>The reset of the timers do not have this bit.
Does it matter if the bit is set on the timers that don't have it or does the HW just ignore it? Or should we enumerate the timers that support it on omap4?
>--
>Tarun
>
>>
>> >
>> >
>> > >
>> > >Also, please Cc linux-arm-kernel.
>> > >
>> > >Thanks,
>> > >
>> > >Kevin
>> > >
>> > >> ---
>> > >> arch/arm/plat-omap/dmtimer.c | 1 +
>> > >> 1 files changed, 1 insertions(+), 0 deletions(-)
>> > >>
>> > >> diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-
>> > >omap/dmtimer.c
>> > >> index 1d706cf..949becc 100644
>> > >> --- a/arch/arm/plat-omap/dmtimer.c
>> > >> +++ b/arch/arm/plat-omap/dmtimer.c
>> > >> @@ -341,6 +341,7 @@ static void omap_dm_timer_reset(struct
>> > >omap_dm_timer *timer)
>> > >> l = omap_dm_timer_read_reg(timer, OMAP_TIMER_OCP_CFG_REG);
>> > >> l |= 0x02 << 3; /* Set to smart-idle mode */
>> > >> l |= 0x2 << 8; /* Set clock activity to perserve f-clock
>on
>> idle
>> > >*/
>> > >> + l |= 0x1 << 0; /* Set autoidle */
>> > >>
>> > >> /*
>> > >> * Enable wake-up on OMAP2 CPUs.
>> > --
>> > To unsubscribe from this list: send the line "unsubscribe linux-
>omap" in
>> > the body of a message to majordomo@vger.kernel.org
>> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap"
>in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] omap: dmtimer: Enable autoidle
2011-02-15 9:45 ` Tero.Kristo
@ 2011-02-15 9:51 ` DebBarma, Tarun Kanti
2011-02-15 12:29 ` Tero.Kristo
0 siblings, 1 reply; 10+ messages in thread
From: DebBarma, Tarun Kanti @ 2011-02-15 9:51 UTC (permalink / raw)
To: Tero.Kristo@nokia.com, Hilman, Kevin; +Cc: linux-omap@vger.kernel.org
[...]
> >> >
> >> > Should this be changed to apply only on that one? I don't know about
> >> > OMAP4, but I think this should work on OMAP2 at least based on spec.
> >> It works on OMAP2 and OMAP4.
> >Ok, on OMAP4 I should have clarified further.
> >AUTOIDLE is present only for millisecond timers: 1,2,10.
> >The reset of the timers do not have this bit.
>
> Does it matter if the bit is set on the timers that don't have it or does
> the HW just ignore it? Or should we enumerate the timers that support it
> on omap4?
For other timers it happens to be SOFTRESET bit. So HW would not ignore.
--
Tarun
> >>
> >> >
> >> >
> >> > >
> >> > >Also, please Cc linux-arm-kernel.
> >> > >
> >> > >Thanks,
> >> > >
> >> > >Kevin
> >> > >
> >> > >> ---
> >> > >> arch/arm/plat-omap/dmtimer.c | 1 +
> >> > >> 1 files changed, 1 insertions(+), 0 deletions(-)
> >> > >>
> >> > >> diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-
> >> > >omap/dmtimer.c
> >> > >> index 1d706cf..949becc 100644
> >> > >> --- a/arch/arm/plat-omap/dmtimer.c
> >> > >> +++ b/arch/arm/plat-omap/dmtimer.c
> >> > >> @@ -341,6 +341,7 @@ static void omap_dm_timer_reset(struct
> >> > >omap_dm_timer *timer)
> >> > >> l = omap_dm_timer_read_reg(timer, OMAP_TIMER_OCP_CFG_REG);
> >> > >> l |= 0x02 << 3; /* Set to smart-idle mode */
> >> > >> l |= 0x2 << 8; /* Set clock activity to perserve f-clock
> >on
> >> idle
> >> > >*/
> >> > >> + l |= 0x1 << 0; /* Set autoidle */
> >> > >>
> >> > >> /*
> >> > >> * Enable wake-up on OMAP2 CPUs.
> >> > --
> >> > To unsubscribe from this list: send the line "unsubscribe linux-
> >omap" in
> >> > the body of a message to majordomo@vger.kernel.org
> >> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-omap"
> >in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] omap: dmtimer: Enable autoidle
2011-02-15 9:51 ` DebBarma, Tarun Kanti
@ 2011-02-15 12:29 ` Tero.Kristo
2011-02-15 12:41 ` DebBarma, Tarun Kanti
0 siblings, 1 reply; 10+ messages in thread
From: Tero.Kristo @ 2011-02-15 12:29 UTC (permalink / raw)
To: tarun.kanti, khilman; +Cc: linux-omap
>-----Original Message-----
>From: ext DebBarma, Tarun Kanti [mailto:tarun.kanti@ti.com]
>Sent: 15 February, 2011 11:52
>To: Kristo Tero (Nokia-MS/Tampere); Hilman, Kevin
>Cc: linux-omap@vger.kernel.org
>Subject: RE: [PATCH] omap: dmtimer: Enable autoidle
>
>[...]
>> >> >
>> >> > Should this be changed to apply only on that one? I don't know
>about
>> >> > OMAP4, but I think this should work on OMAP2 at least based on
>spec.
>> >> It works on OMAP2 and OMAP4.
>> >Ok, on OMAP4 I should have clarified further.
>> >AUTOIDLE is present only for millisecond timers: 1,2,10.
>> >The reset of the timers do not have this bit.
>>
>> Does it matter if the bit is set on the timers that don't have it or
>does
>> the HW just ignore it? Or should we enumerate the timers that support
>it
>> on omap4?
>For other timers it happens to be SOFTRESET bit. So HW would not ignore.
Ok, so this one should only be implemented for omap2/3 or added logic is needed for omap4.
>--
>Tarun
>> >>
>> >> >
>> >> >
>> >> > >
>> >> > >Also, please Cc linux-arm-kernel.
>> >> > >
>> >> > >Thanks,
>> >> > >
>> >> > >Kevin
>> >> > >
>> >> > >> ---
>> >> > >> arch/arm/plat-omap/dmtimer.c | 1 +
>> >> > >> 1 files changed, 1 insertions(+), 0 deletions(-)
>> >> > >>
>> >> > >> diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-
>> >> > >omap/dmtimer.c
>> >> > >> index 1d706cf..949becc 100644
>> >> > >> --- a/arch/arm/plat-omap/dmtimer.c
>> >> > >> +++ b/arch/arm/plat-omap/dmtimer.c
>> >> > >> @@ -341,6 +341,7 @@ static void omap_dm_timer_reset(struct
>> >> > >omap_dm_timer *timer)
>> >> > >> l = omap_dm_timer_read_reg(timer, OMAP_TIMER_OCP_CFG_REG);
>> >> > >> l |= 0x02 << 3; /* Set to smart-idle mode */
>> >> > >> l |= 0x2 << 8; /* Set clock activity to perserve f-clock
>> >on
>> >> idle
>> >> > >*/
>> >> > >> + l |= 0x1 << 0; /* Set autoidle */
>> >> > >>
>> >> > >> /*
>> >> > >> * Enable wake-up on OMAP2 CPUs.
>> >> > --
>> >> > To unsubscribe from this list: send the line "unsubscribe linux-
>> >omap" in
>> >> > the body of a message to majordomo@vger.kernel.org
>> >> > More majordomo info at http://vger.kernel.org/majordomo-
>info.html
>> >> --
>> >> To unsubscribe from this list: send the line "unsubscribe linux-
>omap"
>> >in
>> >> the body of a message to majordomo@vger.kernel.org
>> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] omap: dmtimer: Enable autoidle
2011-02-15 12:29 ` Tero.Kristo
@ 2011-02-15 12:41 ` DebBarma, Tarun Kanti
2011-02-15 16:14 ` Kevin Hilman
0 siblings, 1 reply; 10+ messages in thread
From: DebBarma, Tarun Kanti @ 2011-02-15 12:41 UTC (permalink / raw)
To: Tero.Kristo@nokia.com, Hilman, Kevin; +Cc: linux-omap@vger.kernel.org
[...]
> >> >> >
> >> >> > Should this be changed to apply only on that one? I don't know
> >about
> >> >> > OMAP4, but I think this should work on OMAP2 at least based on
> >spec.
> >> >> It works on OMAP2 and OMAP4.
> >> >Ok, on OMAP4 I should have clarified further.
> >> >AUTOIDLE is present only for millisecond timers: 1,2,10.
> >> >The reset of the timers do not have this bit.
> >>
> >> Does it matter if the bit is set on the timers that don't have it or
> >does
> >> the HW just ignore it? Or should we enumerate the timers that support
> >it
> >> on omap4?
> >For other timers it happens to be SOFTRESET bit. So HW would not ignore.
>
> Ok, so this one should only be implemented for omap2/3 or added logic is
> needed for omap4.
YES.
> >> >>
> >> >> >
> >> >> >
> >> >> > >
> >> >> > >Also, please Cc linux-arm-kernel.
> >> >> > >
> >> >> > >Thanks,
> >> >> > >
> >> >> > >Kevin
> >> >> > >
> >> >> > >> ---
> >> >> > >> arch/arm/plat-omap/dmtimer.c | 1 +
> >> >> > >> 1 files changed, 1 insertions(+), 0 deletions(-)
> >> >> > >>
> >> >> > >> diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-
> >> >> > >omap/dmtimer.c
> >> >> > >> index 1d706cf..949becc 100644
> >> >> > >> --- a/arch/arm/plat-omap/dmtimer.c
> >> >> > >> +++ b/arch/arm/plat-omap/dmtimer.c
> >> >> > >> @@ -341,6 +341,7 @@ static void omap_dm_timer_reset(struct
> >> >> > >omap_dm_timer *timer)
> >> >> > >> l = omap_dm_timer_read_reg(timer, OMAP_TIMER_OCP_CFG_REG);
> >> >> > >> l |= 0x02 << 3; /* Set to smart-idle mode */
> >> >> > >> l |= 0x2 << 8; /* Set clock activity to perserve f-clock
> >> >on
> >> >> idle
> >> >> > >*/
> >> >> > >> + l |= 0x1 << 0; /* Set autoidle */
> >> >> > >>
> >> >> > >> /*
> >> >> > >> * Enable wake-up on OMAP2 CPUs.
> >> >> > --
> >> >> > To unsubscribe from this list: send the line "unsubscribe linux-
> >> >omap" in
> >> >> > the body of a message to majordomo@vger.kernel.org
> >> >> > More majordomo info at http://vger.kernel.org/majordomo-
> >info.html
> >> >> --
> >> >> To unsubscribe from this list: send the line "unsubscribe linux-
> >omap"
> >> >in
> >> >> the body of a message to majordomo@vger.kernel.org
> >> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] omap: dmtimer: Enable autoidle
2011-02-15 12:41 ` DebBarma, Tarun Kanti
@ 2011-02-15 16:14 ` Kevin Hilman
0 siblings, 0 replies; 10+ messages in thread
From: Kevin Hilman @ 2011-02-15 16:14 UTC (permalink / raw)
To: DebBarma, Tarun Kanti; +Cc: Tero.Kristo@nokia.com, linux-omap@vger.kernel.org
"DebBarma, Tarun Kanti" <tarun.kanti@ti.com> writes:
> [...]
>> >> >> >
>> >> >> > Should this be changed to apply only on that one? I don't know
>> >about
>> >> >> > OMAP4, but I think this should work on OMAP2 at least based on
>> >spec.
>> >> >> It works on OMAP2 and OMAP4.
>> >> >Ok, on OMAP4 I should have clarified further.
>> >> >AUTOIDLE is present only for millisecond timers: 1,2,10.
>> >> >The reset of the timers do not have this bit.
>> >>
>> >> Does it matter if the bit is set on the timers that don't have it or
>> >does
>> >> the HW just ignore it? Or should we enumerate the timers that support
>> >it
>> >> on omap4?
>> >For other timers it happens to be SOFTRESET bit. So HW would not ignore.
>>
>> Ok, so this one should only be implemented for omap2/3 or added logic is
>> needed for omap4.
> YES.
>
Tarun is autoidle feature handled in your hwmod conversion series?
If not, this should be implemented as a patch on top of your series
since we will know which timers have this capability.
Kevin
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2011-02-15 16:14 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-14 17:26 [PATCH] omap: dmtimer: Enable autoidle Tero Kristo
2011-02-14 23:28 ` Kevin Hilman
2011-02-15 8:16 ` Tero.Kristo
2011-02-15 9:20 ` DebBarma, Tarun Kanti
2011-02-15 9:31 ` DebBarma, Tarun Kanti
2011-02-15 9:45 ` Tero.Kristo
2011-02-15 9:51 ` DebBarma, Tarun Kanti
2011-02-15 12:29 ` Tero.Kristo
2011-02-15 12:41 ` DebBarma, Tarun Kanti
2011-02-15 16:14 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox