public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: tom.leiming@gmail.com
Cc: tony@atomide.com, linux-omap@vger.kernel.org,
	Felipe Balbi <balbi@ti.com>
Subject: Re: [PATCH] arm: omap4: panda: remove usb_nop_xceiv_register
Date: Tue, 04 Jan 2011 16:29:04 -0800	[thread overview]
Message-ID: <87ipy442i7.fsf@ti.com> (raw)
In-Reply-To: <1294148397-26582-1-git-send-email-tom.leiming@gmail.com> (tom leiming's message of "Tue, 4 Jan 2011 21:39:57 +0800")

tom.leiming@gmail.com writes:

> From: Ming Lei <tom.leiming@gmail.com>
>
> Panda uses twl6030 otg phy instead of internal phy,
> so removes usb_nop_xceiv_register to make musb working.
>
> Cc: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Ming Lei <tom.leiming@gmail.com>

Please Cc the linux-arm-kernel list for OMAP kernel patches targetted
for upstream.

Also, would be nice to get some Reviewed-by and/or Tested-by tags from
Panda users on this one as well.

Kevin

> ---
>  arch/arm/mach-omap2/board-omap4panda.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-omap4panda.c b/arch/arm/mach-omap2/board-omap4panda.c
> index 1ecd0a6..802ae20 100644
> --- a/arch/arm/mach-omap2/board-omap4panda.c
> +++ b/arch/arm/mach-omap2/board-omap4panda.c
> @@ -374,8 +374,6 @@ static void __init omap4_panda_init(void)
>  	platform_add_devices(panda_devices, ARRAY_SIZE(panda_devices));
>  	omap_serial_init();
>  	omap4_twl6030_hsmmc_init(mmc);
> -	/* OMAP4 Panda uses internal transceiver so register nop transceiver */
> -	usb_nop_xceiv_register();
>  	omap4_ehci_init();
>  	/* FIXME: allow multi-omap to boot until musb is updated for omap4 */
>  	if (!cpu_is_omap44xx())

  reply	other threads:[~2011-01-05  0:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-04 13:39 [PATCH] arm: omap4: panda: remove usb_nop_xceiv_register tom.leiming
2011-01-05  0:29 ` Kevin Hilman [this message]
2011-01-05  6:56   ` Felipe Balbi
2011-01-05 13:40     ` Ming Lei
2011-01-05 14:10       ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ipy442i7.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=balbi@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=tom.leiming@gmail.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox