RE: [RFC part1/2 merge][PATCH 06/10] omap3: serial: Fix uart4 handling for 3630

Aguirre, Sergio
2010-03-05T23:12:00Z

From: Kevin Hilman [mailto:khilman@deeprootsystems.com]
Sent: Friday, March 05, 2010 4:38 PM

<snip>

> > @@ -694,6 +698,10 @@ void __init omap_serial_early_init(void)
> >
> > if (cpu_is_omap44xx())
> > p->irq += 32;
> > +
> > + /* IRQ for UART4 in omap3630 is 80 */
> > + if (cpu_is_omap3630() && (i == 3))
> > + p->irq = 80;
>
> Should add a symbolic name to irqs.h and use it here, instead
> of hard-coded constant.

Sounds like a nice idea! Thanks!

I'll update the patchset and resend.

Regards,
Sergio
>
> Kevin