RE: [RFC part1/2 merge][PATCH 06/10] omap3: serial: Fix uart4 handling for 3630

Aguirre, Sergio
2010-03-08T16:57:19Z

From: Kevin Hilman [mailto:khilman@deeprootsystems.com]
Sent: Monday, March 08, 2010 10:52 AM
> "Aguirre, Sergio" <saaguirre@ti.com> writes:
>
> >> -----Original Message-----
> >> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> >> owner@vger.kernel.org] On Behalf Of Aguirre, Sergio
> >> Sent: Friday, March 05, 2010 5:12 PM
> >> To: Kevin Hilman
> >> Cc: linux-omap@vger.kernel.org
> >> Subject: RE: [RFC part1/2 merge][PATCH 06/10] omap3: serial: Fix uart4
> >> handling for 3630
> >>
> >>
> >> From: Kevin Hilman [mailto:khilman@deeprootsystems.com]
> >> Sent: Friday, March 05, 2010 4:38 PM
> >>
> >> <snip>
> >>
> >> > > @@ -694,6 +698,10 @@ void __init omap_serial_early_init(void)
> >> > >
> >> > > if (cpu_is_omap44xx())
> >> > > p->irq += 32;
> >> > > +
> >> > > + /* IRQ for UART4 in omap3630 is 80 */
> >> > > + if (cpu_is_omap3630() && (i == 3))
> >> > > + p->irq = 80;
> >> >
> >> > Should add a symbolic name to irqs.h and use it here, instead
> >> > of hard-coded constant.
> >>
> >> Sounds like a nice idea! Thanks!
> >>
> >> I'll update the patchset and resend.
> >
> > Actually, I have been thinking on a patch to remove all magic numbering,
> also for OMAP4... I'll think about it and include it in the next version.
>
> Don't spend too much time on this.
>
> Soon, this serial core will be converted over to hwmod (RFC patches
> already posted) so all the IRQ and base address stuff will be
> handled by hwmod.

Hmm... ok, thanks for clarifying that.

Then I won't touch anything that my original series doesn't cover.
I'll just use this define for 3630 as you originally suggested here,
and resend.

Regards,
sergio

>
> Kevin
>
>