From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH] OMAP: DMA: Init CDAC to Zero Date: Wed, 03 Mar 2010 10:29:12 -0800 Message-ID: <87iq9dcl8n.fsf@deeprootsystems.com> References: <1267610118-30748-1-git-send-email-manjugk@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pv0-f174.google.com ([74.125.83.174]:55209 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754490Ab0CCS3P (ORCPT ); Wed, 3 Mar 2010 13:29:15 -0500 Received: by pvb32 with SMTP id 32so76030pvb.19 for ; Wed, 03 Mar 2010 10:29:15 -0800 (PST) In-Reply-To: <1267610118-30748-1-git-send-email-manjugk@ti.com> (Manjunatha GK's message of "Wed\, 3 Mar 2010 15\:25\:18 +0530") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Manjunatha GK Cc: linux-omap@vger.kernel.org, Tony Lindgren , Santosh Shilimkar , Govindraj R Manjunatha GK writes: > The register DMA4_CDAC needs to be initialized to zero > before starting DMA transfer. > > Cc: Tony Lindgren > Cc: Santosh Shilimkar > Cc: Govindraj R > Cc: Kevin Hilman > Reported-by:S, Venkatraman > Signed-off-by: Manjunatha GK > --- > It was aligned to reset CDAC to zero in omap_start_dma(int lch) > instead of creating new API for accessing CDAC register. > > Discussion thread is at: > http://patchwork.kernel.org/patch/83176/ > http://patchwork.kernel.org/patch/82948/ > > > arch/arm/plat-omap/dma.c | 8 ++++++++ > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c > index 2ab224c..96741d4 100644 > --- a/arch/arm/plat-omap/dma.c > +++ b/arch/arm/plat-omap/dma.c > @@ -936,6 +936,14 @@ void omap_start_dma(int lch) > { > u32 l; > > + /* CPC/CDAC register needs to be initialized to zero > + * before starting dma transfer. > + */ Please fix the multi-line comment style. Search for 'multi-line' in Documentation/CodingStyle for details. Kevin > + if (cpu_is_omap15xx()) > + dma_write(0, CPC(lch)); > + else > + dma_write(0, CDAC(lch)); > + > if (!omap_dma_in_1510_mode() && dma_chan[lch].next_lch != -1) { > int next_lch, cur_lch; > char dma_chan_link_map[OMAP_DMA4_LOGICAL_DMA_CH_COUNT]; > -- > 1.6.0.4