Re: [PATCH] AM35xx: Clock table updates for AM3505/17

[Kevin Hilman <khilman@deeprootsystems.com>]

Ranjith Lohithakshan <ranjithl@ti.com> writes:

> AM3505/17 though a OMAP3530 derivative have the following
> main differences
>
> 	- Removal of the following OMAP3 modules
> 		- IVA
> 		- ISP/CAM
> 		- Modem and D2D components (MAD2D, SAD2D)
> 		- USIM
> 		- SSI
> 		- Mailboxes
> 		- USB OTG
> 		- ICR
> 		- MSPRO
> 		- SmartReflex
> 	- SDRC replaced with EMIF4 Controller in the SDRC subsystem
> 	  thus adding support for DDR2 memory devices
> 	- Addition of the following new modules
> 		- Ethernet MAC (CPGMAC)
> 		- CAN Controller (HECC)
> 		- New USB OTG Controller with integrated Phy
> 		- Video Processing Front End (VPFE)
> 		- Additional UART (UART4)
> 	- All security accelerators disabled on GP devices and not to
> 	  be accessed or configured
>
> This patch defines CPU flags for AM3505/17 and update the clock table.
> Clock support for new modules will be added by subsequent patches.
>
> Signed-off-by: Ranjith Lohithakshan <ranjithl@ti.com>

A question on the approach here, as I'm wondering if this approach is
really needed.

Rather than handling these details in the clock tree, why not handle
the special cases using the feature checks: omap_has_*().  

Kevin