From: Kevin Hilman <khilman@deeprootsystems.com>
To: "Dasgupta, Romit" <romit@ti.com>, Paul Walmsley <paul@pwsan.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] omap-pm: Fixes behaviour of some shared resource framework functions
Date: Tue, 13 Oct 2009 12:06:24 -0700 [thread overview]
Message-ID: <87iqejktan.fsf@deeprootsystems.com> (raw)
In-Reply-To: <B85A65D85D7EB246BE421B3FB0FBB59301DDCE4650@dbde02.ent.ti.com> (Romit Dasgupta's message of "Wed\, 7 Oct 2009 18\:11\:50 +0530")
"Dasgupta, Romit" <romit@ti.com> writes:
> (Tested on Zoom2).
>
> 'omap_pm_dsp_set_min_opp' & 'omap_pm_cpu_set_freq' were using their own
> struct device *. This is a problem because invoking these functions from
> different clients would result in setting of the resource level as requested by
> the last caller. Fixes this by introducing a struct device * to the parameter
> list for these functions.
> Signed-off-by: Romit Dasgupta <romit@ti.com>
This looks like the right fix to me.
Paul, any comments?
Kevin
next prev parent reply other threads:[~2009-10-13 19:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-07 12:41 [PATCH] omap-pm: Fixes behaviour of some shared resource framework functions Dasgupta, Romit
2009-10-13 19:06 ` Kevin Hilman [this message]
2009-10-28 18:29 ` Paul Walmsley
2009-10-28 18:38 ` Paul Walmsley
2009-10-28 22:08 ` Madhusudhan
2009-10-28 22:45 ` Kevin Hilman
2009-10-29 7:39 ` Dasgupta, Romit
2009-10-29 11:16 ` Mark Brown
2009-10-29 12:42 ` Cousson, Benoit
2009-10-29 14:52 ` Dasgupta, Romit
2009-10-29 15:42 ` Kevin Hilman
2009-10-29 21:37 ` Mike Turquette
2009-10-29 22:22 ` Madhusudhan
2009-10-29 23:32 ` Kevin Hilman
2009-10-30 9:43 ` Titiano, Patrick
2009-10-30 7:58 ` Dasgupta, Romit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iqejktan.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=romit@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox