From: Kevin Hilman <khilman@deeprootsystems.com>
To: linux-arm-kernel@lists.arm.linux.org.uk
Cc: linux-omap@vger.kernel.org, Eero Nurkkala <ext-eero.nurkkala@nokia.com>
Subject: Re: [PATCH 12/11] OMAP: PM: CPUfreq: obey min/max settings of policy
Date: Thu, 25 Jun 2009 10:17:13 -0700 [thread overview]
Message-ID: <87iqikqlly.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1245949702-26243-1-git-send-email-khilman@deeprootsystems.com> (Kevin Hilman's message of "Thu\, 25 Jun 2009 10\:08\:22 -0700")
yes, this is patch 12 of 11. :)
It's an extra patch that should've been included in the original
series.
Kevin
Kevin Hilman <khilman@deeprootsystems.com> writes:
> From: Eero Nurkkala <ext-eero.nurkkala@nokia.com>
>
> Use the min/max settings from CPUfreq policy rather than
> processor defined min/max settings.
>
> Without this patch, it's possible to scale frequency outside
> the current policy range.
>
> Signed-off-by: Eero Nurkkala <ext-eero.nurkkala@nokia.com>
> Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
> ---
> arch/arm/plat-omap/cpu-omap.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/plat-omap/cpu-omap.c b/arch/arm/plat-omap/cpu-omap.c
> index 843e8af..1868c0d 100644
> --- a/arch/arm/plat-omap/cpu-omap.c
> +++ b/arch/arm/plat-omap/cpu-omap.c
> @@ -78,10 +78,10 @@ static int omap_target(struct cpufreq_policy *policy,
>
> /* Ensure desired rate is within allowed range. Some govenors
> * (ondemand) will just pass target_freq=0 to get the minimum. */
> - if (target_freq < policy->cpuinfo.min_freq)
> - target_freq = policy->cpuinfo.min_freq;
> - if (target_freq > policy->cpuinfo.max_freq)
> - target_freq = policy->cpuinfo.max_freq;
> + if (target_freq < policy->min)
> + target_freq = policy->min;
> + if (target_freq > policy->max)
> + target_freq = policy->max;
>
> freqs.old = omap_getspeed(0);
> freqs.new = clk_round_rate(mpu_clk, target_freq * 1000) / 1000;
> --
> 1.6.3.2
prev parent reply other threads:[~2009-06-25 17:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-25 16:41 [PATCH 00/11] OMAP fixes from PM branch for .31-rc Kevin Hilman
2009-06-25 16:41 ` [PATCH 01/11] OMAP: SDRC: Add several new register definitions Kevin Hilman
2009-06-25 16:41 ` [PATCH 02/11] OMAP2/3: PM: make PM __init calls static Kevin Hilman
2009-06-25 16:41 ` [PATCH 03/11] OMAP3: PM: CM_REGADDR macros using wrong name Kevin Hilman
2009-06-25 16:41 ` [PATCH 04/11] OMAP3: PM: Ensure PRCM interrupts are cleared at boot Kevin Hilman
2009-06-25 16:41 ` [PATCH 05/11] OMAP3: PM: Clear pending PRCM reset flags on init Kevin Hilman
2009-06-25 16:41 ` [PATCH 06/11] OMAP3: PM: prevent module wakeups from waking IVA2 Kevin Hilman
2009-06-25 16:42 ` [PATCH 07/11] OMAP3: PM: Do not build suspend code if SUSPEND is not enabled Kevin Hilman
2009-06-25 16:42 ` [PATCH 08/11] OMAP3: PM: reset USB OTG module on boot Kevin Hilman
2009-06-25 16:42 ` [PATCH 09/11] OMAP4: UART: cleanup special case IRQ handling Kevin Hilman
2009-06-25 16:42 ` [PATCH 10/11] OMAP3: Fixed crash bug with serial + suspend Kevin Hilman
2009-06-25 16:42 ` [PATCH 11/11] OMAP2/3/4: UART: Allow per-UART disabling wakeup for serial ports Kevin Hilman
2009-06-25 17:08 ` [PATCH 12/11] OMAP: PM: CPUfreq: obey min/max settings of policy Kevin Hilman
2009-06-25 17:17 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iqikqlly.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=ext-eero.nurkkala@nokia.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox