From: Kevin Hilman <khilman@deeprootsystems.com>
To: "Nayak, Rajendra" <rnayak@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] OMAP3: PM: Update correct ONLP/RET values
Date: Tue, 03 Mar 2009 08:41:58 -0800 [thread overview]
Message-ID: <87iqmq7e3t.fsf@deeprootsystems.com> (raw)
In-Reply-To: <5A47E75E594F054BAF48C5E4FC4B92AB02FAD03A7B@dbde02.ent.ti.com> (Rajendra Nayak's message of "Mon\, 2 Mar 2009 13\:01\:09 +0530")
"Nayak, Rajendra" <rnayak@ti.com> writes:
> Populates the correct ONLP/RET cmd values for VDD1 and VDD2.
> Also removes the unneccesary bitshift logic.
> Applies on the latest pm branch, validated on a 3430SDP.
>
> 0x30 = 1.2V
> 0x1E = .975V
> 0x2C = 1.15V
>
> Formula used to calulate the hex values
> Value(in decimals)*12.5 + 600 mV.
>
> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
Thanks, I will merge this with your previous patch and push a new pm branch.
Kevin
> arch/arm/mach-omap2/pm34xx.c | 16 ++++++++--------
> 1 files changed, 8 insertions(+), 8 deletions(-)
>
> Index: linux-omap-2.6/arch/arm/mach-omap2/pm34xx.c
> ===================================================================
> --- linux-omap-2.6.orig/arch/arm/mach-omap2/pm34xx.c 2009-03-02 11:42:13.000000000 +0530
> +++ linux-omap-2.6/arch/arm/mach-omap2/pm34xx.c 2009-03-02 12:07:19.653034656 +0530
> @@ -1036,16 +1036,16 @@ err2:
> }
>
> /* PRM_VC_CMD_VAL_0 specific bits */
> -#define OMAP3430_VC_CMD_VAL0_ON (0x3 << 4)
> -#define OMAP3430_VC_CMD_VAL0_ONLP (0xf << 3)
> -#define OMAP3430_VC_CMD_VAL0_RET (0xf << 3)
> -#define OMAP3430_VC_CMD_VAL0_OFF (0x3 << 4)
> +#define OMAP3430_VC_CMD_VAL0_ON 0x30
> +#define OMAP3430_VC_CMD_VAL0_ONLP 0x1E
> +#define OMAP3430_VC_CMD_VAL0_RET 0x1E
> +#define OMAP3430_VC_CMD_VAL0_OFF 0x30
>
> /* PRM_VC_CMD_VAL_1 specific bits */
> -#define OMAP3430_VC_CMD_VAL1_ON (0xB << 2)
> -#define OMAP3430_VC_CMD_VAL1_ONLP (0xf << 3)
> -#define OMAP3430_VC_CMD_VAL1_RET (0xf << 3)
> -#define OMAP3430_VC_CMD_VAL1_OFF (0xB << 2)
> +#define OMAP3430_VC_CMD_VAL1_ON 0x2C
> +#define OMAP3430_VC_CMD_VAL1_ONLP 0x1E
> +#define OMAP3430_VC_CMD_VAL1_RET 0x1E
> +#define OMAP3430_VC_CMD_VAL1_OFF 0x2C
>
> static void __init configure_vc(void)
> {--
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2009-03-03 16:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 7:31 [PATCH] OMAP3: PM: Update correct ONLP/RET values Nayak, Rajendra
2009-03-03 16:41 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iqmq7e3t.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=rnayak@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox