From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 3/8] omap3: pm: Correcting the sys_offmode signal polarity Date: Tue, 01 Mar 2011 14:35:04 -0800 Message-ID: <87k4gifp0n.fsf@ti.com> References: <1298723139-1693-1-git-send-email-leslyam@ti.com> <1298723139-1693-4-git-send-email-leslyam@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aog106.obsmtp.com ([74.125.149.77]:56343 "EHLO na3sys009aog106.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756168Ab1CAWfK (ORCPT ); Tue, 1 Mar 2011 17:35:10 -0500 Received: by mail-pz0-f42.google.com with SMTP id 12so1466196pzk.15 for ; Tue, 01 Mar 2011 14:35:07 -0800 (PST) In-Reply-To: <1298723139-1693-4-git-send-email-leslyam@ti.com> (Lesly A. M.'s message of "Sat, 26 Feb 2011 17:55:34 +0530") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Lesly A M Cc: linux-omap@vger.kernel.org, Nishanth Menon , David Derrick , Samuel Ortiz Lesly A M writes: > Changing the polarity of the sys_offmode signal to active low, > to get a High to Low transition on the NSLEEP1 of PM IC when OMAP is > entering offmode. Because on PM IC the power resources (LDO, DCDC regulators) > associated with P1 group which is controlled by NSLEEP1 are set to sleep, > when there is transition form High to Low. > > Signed-off-by: Lesly A M > Cc: Nishanth Menon > Cc: David Derrick > Cc: Samuel Ortiz > --- > arch/arm/mach-omap2/pm34xx.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c > index e46f4b5..8a7c756 100644 > --- a/arch/arm/mach-omap2/pm34xx.c > +++ b/arch/arm/mach-omap2/pm34xx.c > @@ -1034,6 +1034,10 @@ static int __init omap3_pm_init(void) > > printk(KERN_ERR "Power Management for TI OMAP3.\n"); > > + /* Changing the polarity of the sys_offmode signal to active low */ > + omap2_prm_clear_mod_reg_bits(OMAP3430_OFFMODE_POL_MASK, > + OMAP3430_GR_MOD, OMAP3_PRM_POLCTRL_OFFSET); > + This change belongs in voltage code. Kevin > /* XXX prcm_setup_regs needs to be before enabling hw > * supervised mode for powerdomains */ > prcm_setup_regs();