From: Kevin Hilman <khilman@deeprootsystems.com>
To: Omar Ramirez Luna <omar.ramirez@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
Hiroshi DOYU <Hiroshi.DOYU@nokia.com>,
Felipe Contreras <felipe.contreras@gmail.com>,
Dmitry Kasatkin <dmitry.kasatkin@nokia.com>,
Suman Anna <s-anna@ti.com>, Paul Walmsley <paul@pwsan.com>,
Benoit Cousson <b-cousson@ti.com>,
"Govindraj.R" <govindraj.raja@ti.com>,
C A Subramaniam <subramaniam.ca@ti.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/5] omap: mailbox: initial hwmod support for omap3
Date: Tue, 09 Nov 2010 15:38:49 -0800 [thread overview]
Message-ID: <87k4kmgj92.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1288129984-22957-2-git-send-email-omar.ramirez@ti.com> (Omar Ramirez Luna's message of "Tue, 26 Oct 2010 16:53:00 -0500")
Omar Ramirez Luna <omar.ramirez@ti.com> writes:
> From: Felipe Contreras <felipe.contreras@gmail.com>
>
> HWMOD support for omap3.
-ENO_DESCRIPTIVE_CHANGELOG
Please describe in more detail what is happening here, starting with a
better subject:
omap: mailbox: build device using omap_device/omap_hwmod
and the changelog should describe that what is being changed is that
there is no longer a need for static platform_device and resources since
all of this data is contained in the omap_hwmod for the mailbox.
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
> ---
> arch/arm/mach-omap2/devices.c | 100 ++++-----------------------
> arch/arm/mach-omap2/mailbox.c | 1 +
> arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 54 +++++++++++++++
please separate out the addition of hwmod_data into it's own patch that
comes before this. As mentioned by Charu, all the hwmod data could be
added early in the series, before this conversion is done.
Kevin
next prev parent reply other threads:[~2010-11-09 23:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 21:52 [PATCH 0/5] omap: mailbox: hwmod support and dependent cleanup patches Omar Ramirez Luna
2010-10-26 21:53 ` [PATCH 1/5] omap: mailbox: initial hwmod support for omap3 Omar Ramirez Luna
2010-10-27 5:07 ` Varadarajan, Charulatha
2010-10-27 11:50 ` Omar Ramirez Luna
2010-11-09 23:38 ` Kevin Hilman [this message]
2010-11-10 3:08 ` Ramirez Luna, Omar
2010-10-26 21:53 ` [PATCH 2/5] omap: mailbox: initial hwmod support for omap2 Omar Ramirez Luna
2010-10-27 5:07 ` Varadarajan, Charulatha
2010-10-26 21:53 ` [PATCH 3/5] omap: mailbox: add omap_device latency information Omar Ramirez Luna
2010-11-09 23:48 ` Kevin Hilman
2010-11-10 1:18 ` Felipe Contreras
2010-11-10 3:03 ` Ramirez Luna, Omar
2010-10-26 21:53 ` [PATCH 4/5] omap: mailbox: fix detection for previously supported chips Omar Ramirez Luna
2010-10-27 5:06 ` Varadarajan, Charulatha
2010-10-27 7:28 ` Felipe Contreras
2010-10-27 9:00 ` Grazvydas Ignotas
2010-10-27 9:46 ` Felipe Contreras
2010-10-26 21:53 ` [PATCH 5/5] omap: mailbox: remove unreachable return Omar Ramirez Luna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k4kmgj92.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=Hiroshi.DOYU@nokia.com \
--cc=b-cousson@ti.com \
--cc=dmitry.kasatkin@nokia.com \
--cc=felipe.contreras@gmail.com \
--cc=govindraj.raja@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=omar.ramirez@ti.com \
--cc=paul@pwsan.com \
--cc=s-anna@ti.com \
--cc=subramaniam.ca@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox