From: Kevin Hilman <khilman@deeprootsystems.com>
To: Thara Gopinath <thara@ti.com>
Cc: linux-omap@vger.kernel.org, paul@pwsan.com, b-cousson@ti.com,
vishwanath.bs@ti.com, sawant@ti.com
Subject: Re: [PATCH v3 08/11] OMAP3: PM: Adding debug support to Voltage and Smartreflex drivers
Date: Wed, 29 Sep 2010 16:20:15 -0700 [thread overview]
Message-ID: <87k4m4qgr4.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1285166719-19352-9-git-send-email-thara@ti.com> (Thara Gopinath's message of "Wed, 22 Sep 2010 20:15:16 +0530")
Thara Gopinath <thara@ti.com> writes:
[...]
> diff --git a/arch/arm/plat-omap/include/plat/voltage.h b/arch/arm/plat-omap/include/plat/voltage.h
> index 99836a1..8978d33 100644
> --- a/arch/arm/plat-omap/include/plat/voltage.h
> +++ b/arch/arm/plat-omap/include/plat/voltage.h
> @@ -14,6 +14,11 @@
> #ifndef __ARCH_ARM_MACH_OMAP2_VOLTAGE_H
> #define __ARCH_ARM_MACH_OMAP2_VOLTAGE_H
>
> +extern u32 enable_sr_vp_debug;
> +#ifdef CONFIG_PM_DEBUG
> +extern struct dentry *pm_dbg_main_dir;
> +#endif
> +
> #define VOLTSCALE_VPFORCEUPDATE 1
> #define VOLTSCALE_VCBYPASS 2
This belongs in PATCH 1/11 and belongs in pm.h, not voltage.h as it's a
feature of the PM debug layer, not the voltage layer.
Kevin
next prev parent reply other threads:[~2010-09-29 23:20 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-22 14:45 [PATCH v3 00/11] OMAP3: Adding Smartreflex and Voltage driver support Thara Gopinath
2010-09-22 14:45 ` [PATCH v3 01/11] OMAP: PM: Export the main pm debugfs directory Thara Gopinath
2010-10-25 9:29 ` Cousson, Benoit
2010-10-25 9:30 ` Gopinath, Thara
2010-09-22 14:45 ` [PATCH v3 02/11] OMAP3: PM: Adding voltage driver support for OMAP3 Thara Gopinath
2010-09-29 21:21 ` Kevin Hilman
2010-09-30 0:27 ` Kevin Hilman
[not found] ` <87bp7gm3dq.fsf@deeprootsystems.com>
2010-09-30 17:39 ` Paul Walmsley
2010-10-15 13:47 ` Cousson, Benoit
2010-10-14 18:05 ` Kevin Hilman
2010-10-22 14:23 ` Gopinath, Thara
2010-10-22 16:18 ` Kevin Hilman
2010-09-22 14:45 ` [PATCH v3 03/11] OMAP3: PM: Adding smartreflex driver support Thara Gopinath
2010-09-28 23:30 ` Kevin Hilman
2010-09-29 14:41 ` Gopinath, Thara
2010-10-14 0:04 ` Kevin Hilman
2010-10-22 14:21 ` Gopinath, Thara
2010-10-22 16:17 ` Kevin Hilman
2010-10-25 11:12 ` Grazvydas Ignotas
2010-09-22 14:45 ` [PATCH v3 04/11] OMAP3: PM: Adding smartreflex device file Thara Gopinath
2010-10-14 19:29 ` Kevin Hilman
2010-10-22 14:36 ` Gopinath, Thara
2010-10-22 16:32 ` Kevin Hilman
2010-10-23 10:55 ` Gopinath, Thara
2010-11-10 18:55 ` Kevin Hilman
2010-09-22 14:45 ` [PATCH v3 05/11] OMAP3: PM: Adding smartreflex hwmod data Thara Gopinath
2010-09-22 14:45 ` [PATCH v3 06/11] OMAP3: PM: Adding smartreflex class3 driver Thara Gopinath
2010-10-14 23:09 ` Kevin Hilman
2010-10-22 14:37 ` Gopinath, Thara
2010-09-22 14:45 ` [PATCH v3 07/11] OMAP3: PM: Adding T2 enabling of smartreflex support Thara Gopinath
2010-09-29 0:08 ` Kevin Hilman
2010-09-29 14:41 ` Gopinath, Thara
2010-09-29 23:16 ` Kevin Hilman
2010-09-22 14:45 ` [PATCH v3 08/11] OMAP3: PM: Adding debug support to Voltage and Smartreflex drivers Thara Gopinath
2010-09-29 23:20 ` Kevin Hilman [this message]
2010-09-30 5:58 ` Gopinath, Thara
2010-10-14 19:20 ` Kevin Hilman
2010-10-22 14:47 ` Gopinath, Thara
2010-10-14 23:46 ` Kevin Hilman
2010-10-22 14:41 ` Gopinath, Thara
2010-10-22 16:52 ` Kevin Hilman
2010-10-25 9:00 ` Gopinath, Thara
2010-10-25 16:19 ` Kevin Hilman
2010-10-25 9:28 ` Cousson, Benoit
2010-09-22 14:45 ` [PATCH v3 09/11] OMAP3: PM: Smartreflex Class3 initialization from board files Thara Gopinath
2010-10-14 23:50 ` Kevin Hilman
2010-10-22 14:43 ` Gopinath, Thara
2010-10-22 16:37 ` Kevin Hilman
2010-10-25 9:16 ` Gopinath, Thara
2010-09-22 14:45 ` [PATCH v3 10/11] OMAP3: PM: Program correct init voltages for VDD1 and VDD2 Thara Gopinath
2010-10-14 23:53 ` Kevin Hilman
2010-10-22 14:44 ` Gopinath, Thara
2010-10-22 16:44 ` Kevin Hilman
2010-09-22 14:45 ` [PATCH v3 11/11] OMAP3: PM: Register TWL4030 pmic info with the voltage driver Thara Gopinath
2010-09-29 0:31 ` [PATCH v3 00/11] OMAP3: Adding Smartreflex and Voltage driver support Kevin Hilman
2010-09-29 1:02 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k4m4qgr4.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=b-cousson@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=sawant@ti.com \
--cc=thara@ti.com \
--cc=vishwanath.bs@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).