Re: ARM: OMAP: Overo: use new gpmc nand infrastructure

[Kevin Hilman <khilman@deeprootsystems.com>]

Steve Sakoman <sakoman@gmail.com> writes:

> On Wed, Apr 7, 2010 at 10:41 AM, Kevin Hilman
> <khilman@deeprootsystems.com> wrote:
>> Steve Sakoman <steve@sakoman.com> writes:
>>
>>> From: Steve Sakoman <steve@sakoman.com>
>>>
>>> Signed-off-by: Steve Sakoman <steve@sakoman.com>
>>
>> -ENOCHANGELOG
>>
>> Please add descriptive changelog.  Otherwise, looks like a good
>> cleanup.
>
> I assume you looking for something like:
>
> Restores nand functionality after changes in commit
> 2f70a1e93657bea0baa7d449aa49e44a08582dc8

Personally, I'd rather see a text summary of the commit (plus commit
ID) so I don't have to follow a commit ID unless I really want the
details.  Something like:

"A new GPMC NAND infrastructure was added by commit foo.  This patch
updates Overo NAND functionally to work with those changes."

or similar.  Since the changelogs become permanent git history, it's
important that they be descriptive and useful long after the initial
commits are done and we've all forgotten about the details.

> If so I'll add it after waiting a bit for any other comments.  I
> assume you are also OK with the similar patch for Beagleboard?

Yes, with a good changelog.  ;)


-- Kevin (changelog cop) Hilman