From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCHv2] OMAP3: PM: Ensure MUSB is accessible before we attempt to reset it Date: Tue, 18 Aug 2009 11:04:44 +0200 Message-ID: <87k511lcgj.fsf@deeprootsystems.com> References: <1250196401-24433-1-git-send-email-jon-hunter@ti.com> <87prazcq5g.fsf@deeprootsystems.com> <4A859DF7.1070303@ti.com> <87fxbu8dvb.fsf@deeprootsystems.com> <20090817081359.GM7278@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-px0-f196.google.com ([209.85.216.196]:62180 "EHLO mail-px0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750847AbZHRJEt (ORCPT ); Tue, 18 Aug 2009 05:04:49 -0400 Received: by pxi34 with SMTP id 34so1691413pxi.4 for ; Tue, 18 Aug 2009 02:04:50 -0700 (PDT) In-Reply-To: <20090817081359.GM7278@atomide.com> (Tony Lindgren's message of "Mon\, 17 Aug 2009 11\:13\:59 +0300") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tony Lindgren Cc: Jon Hunter , linux-omap Tony Lindgren writes: > * Kevin Hilman [090814 21:11]: >> Jon Hunter writes: >> >> > Kevin Hilman wrote: >> >> Jon, you're raising the bar and spoiling us with such descriptive >> >> changelogs. If everyone was as thorough as you, the world would be a >> >> merrier place. :) >> >> >> >> Thanks, pushing to PM branch and pm-2.6.29. >> >> >> >> Kevin >> > >> > No problem. You are welcome. Just an FYI, but for 2.6.29, I was doing >> > some testing this morning and I found that I needed to make the >> > following change to the patch to make it work for 2.6.29. You are >> > probably aware already as this makes the patch similar to your >> > original patch for mmc-reset. >> > >> > - dev_set_name(dev, "musb_hdrc"); >> > - otg_clk = clk_get(dev, "ick"); >> > + otg_clk = clk_get(dev, "hsotgusb_ick"); >> >> Ah yes, I thought of that when I first saw the patch but forgot to do >> that on pm-2.6.29. >> >> Thanks, pushing to pm-2.6.29. > > Where's the dependency with this patch to the PM branch? If there is > a dependency, can it be removed for mainline? > > To me it looks like we should send a patch against the mainline tree via > linux-usb list. No, this is a temporary patch until OTG support is added to omap_hwmod. Kevin