From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH] ARM: OMAP: omap_device: fix return value check in omap_device_build_ss() Date: Tue, 02 Oct 2012 14:36:52 -0700 Message-ID: <87lifo8sjv.fsf@deeprootsystems.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pa0-f46.google.com ([209.85.220.46]:64263 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756548Ab2JBVgw (ORCPT ); Tue, 2 Oct 2012 17:36:52 -0400 Received: by padhz1 with SMTP id hz1so5639563pad.19 for ; Tue, 02 Oct 2012 14:36:52 -0700 (PDT) In-Reply-To: (Wei Yongjun's message of "Fri, 21 Sep 2012 14:32:04 +0800") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Wei Yongjun Cc: tony@atomide.com, linux@arm.linux.org.uk, grant.likely@secretlab.ca, rob.herring@calxeda.com, yongjun_wei@trendmicro.com.cn, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree-discuss@lists.ozlabs.org Wei Yongjun writes: > From: Wei Yongjun > > In case of error, the function omap_device_alloc() returns ERR_PTR() > and never returns NULL pointer. The NULL test in the return value > check should be replaced with IS_ERR(). > > dpatch engine is used to auto generated this patch. > (https://github.com/weiyj/dpatch) > > Signed-off-by: Wei Yongjun Thanks, queueing this for v3.7-rc. Kevin