From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCHv4 7/8] ARM: OMAP: clockdomain: add support for preventing autodep delete Date: Fri, 27 Jul 2012 13:12:47 -0700 Message-ID: <87lii5hsjk.fsf@ti.com> References: <1342189185-5306-1-git-send-email-t-kristo@ti.com> <1342189185-5306-8-git-send-email-t-kristo@ti.com> <5003F453.9020903@ti.com> <1342536971.4672.82.camel@sokoban> <50066284.1030903@ti.com> <1342598720.4672.83.camel@sokoban> <50067C0D.2040508@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aog102.obsmtp.com ([74.125.149.69]:58915 "EHLO na3sys009aog102.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752602Ab2G0UNX (ORCPT ); Fri, 27 Jul 2012 16:13:23 -0400 Received: by pbbrr13 with SMTP id rr13so6742259pbb.26 for ; Fri, 27 Jul 2012 13:13:04 -0700 (PDT) In-Reply-To: <50067C0D.2040508@ti.com> (Rajendra Nayak's message of "Wed, 18 Jul 2012 14:34:13 +0530") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Rajendra Nayak Cc: t-kristo@ti.com, linux-omap@vger.kernel.org, paul@pwsan.com, linux-arm-kernel@lists.infradead.org Rajendra Nayak writes: > On Wednesday 18 July 2012 01:35 PM, Tero Kristo wrote: >> On Wed, 2012-07-18 at 12:45 +0530, Rajendra Nayak wrote: >>> On Tuesday 17 July 2012 08:26 PM, Tero Kristo wrote: >>>> Anyway, it also looks like this fix is no longer needed with the latest >>>> kernel, something has changed with the gpio code / or latencies and it >>>> doesn't crash anymore. Thus, it looks like patches 7& 8 can be dropped >>>> from this set for now. This is the behavior with beagleboard at least, >>>> if someone can verify this with some other omap3 hw that would be nice. >>> >>> I can test it on a omap3 SDP. What do you want me to test? >> >> Just try suspend + cpuidle with and without off-mode enabled and see if >> there are any problems. I've usually seen problems with off-mode myself. > > So I just knocked off the last 2 patches from 'mainline-3.5-rc6-pwrdm- > changes-v4' and tested on my 3430 SDP. > > I was able to hit RET and OFF in both suspend and cpuidle. Did not see > any issues. > FYI... I tested this series without the last 2 patches on top of v3.5 and suspend/resume hangs on 3430/n900, 3530/Overo, 3730/OveroSTORM, but suspend/resume and cpuidle tests for retention and idle seem to work fine on 3730/Beagle-xM. It works fine on all the platforms with the last 2 applied (note 6/8 needs a minor update to apply cleanly to mainline v3.5.) Kevin