From: Kevin Hilman <khilman@ti.com>
To: Vishwanath Sripathy <vishwanath.bs@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Tero Kristo <t-kristo@ti.com>,
linux-omap@vger.kernel.org
Subject: Re: [RFC 1/2] OMAP3+: voltage / oscillator parameter segregation
Date: Mon, 29 Aug 2011 09:07:36 -0700 [thread overview]
Message-ID: <87liucw69j.fsf@ti.com> (raw)
In-Reply-To: <d74484cd55c8314a364af834fbbede0f@mail.gmail.com> (Vishwanath Sripathy's message of "Sat, 27 Aug 2011 14:59:22 +0530")
Vishwanath Sripathy <vishwanath.bs@ti.com> writes:
[...]
>> >> diff --git a/arch/arm/mach-omap2/opp3xxx_data.c b/arch/arm/mach-
>> omap2/opp3xxx_data.c
>> >> index d95f3f9..b5d8294 100644
>> >> --- a/arch/arm/mach-omap2/opp3xxx_data.c
>> >> +++ b/arch/arm/mach-omap2/opp3xxx_data.c
>> >> @@ -26,6 +26,16 @@
>> >> #include "pm.h"
>> >>
>> >> /* 34xx */
>> >> +/* OMAP VP parameter values */
>> >> +#define OMAP3430_VP1_VLIMITTO_VDDMIN 0x14
>> >> +#define OMAP3430_VP1_VLIMITTO_VDDMAX 0x42
>> >> +#define OMAP3430_VP2_VLIMITTO_VDDMIN 0x18
>> >> +#define OMAP3430_VP2_VLIMITTO_VDDMAX 0x2c
>>> NAK -> we should be using voltages here -> depending on the PMIC
>>> used, the rounding factor may not map to TWL4030.
>>
>> Agreed.
>>
>> > I had posted patch for this earlier I believe in series
>> > http://marc.info/?l=linux-omap&m=130741297821372&w=2
>>
>> I know you're a bit distracted currently ;) but is there any chance
>> you can refresh at least this patch:
>>
>> OMAP3+: PM: VP: use uV for max and min voltage limits
>>
>> from your series on top of my current pm-wip/voltdm branch?
>>
>> If not, maybe point us to an archived version and Tero can pick it up
>> and add it to this series. After a quick search, I couldn't find it
>> in the marc.info archives.
>
> Below link should help I suppose.
> https://patchwork.kernel.org/patch/855172/
>
Yes, Tero should pick this one up and add it to his series to address
Nishanth's concerns.
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-08-29 16:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-03 15:29 [RFC 0/2] voltage / oscillator parameter segregation Tero Kristo
2011-08-03 15:29 ` [RFC 1/2] OMAP3+: " Tero Kristo
2011-08-04 13:57 ` Vishwanath Sripathy
2011-08-05 7:28 ` Tero Kristo
2011-08-07 16:30 ` Menon, Nishanth
2011-08-26 23:24 ` Kevin Hilman
2011-08-27 9:29 ` Vishwanath Sripathy
2011-08-29 16:07 ` Kevin Hilman [this message]
2011-08-03 15:29 ` [RFC 2/2] TEMP: OMAP3: beagle: added dummy vdd ramp up and clock setup times Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87liucw69j.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=t-kristo@ti.com \
--cc=vishwanath.bs@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox