Re: [PATCH] OMAP: GPIO: Fix OMAP4 GPIO reg access issues

[Kevin Hilman <khilman@deeprootsystems.com>]

"Varadarajan, Charulatha" <charu@ti.com> writes:

> ________________________________________
>> From: Kevin Hilman [khilman@deeprootsystems.com]
>> Sent: Wednesday, April 07, 2010 4:21 AM
>> To: Varadarajan, Charulatha
>> Cc: linux-omap@vger.kernel.org
>> Subject: Re: [PATCH] OMAP: GPIO: Fix OMAP4 GPIO reg access issues
>> 
>> Charulatha V <charu@ti.com> writes:
>> 
>> > Access to some of the OMAP4 GPIO registers are not properly handled.
>> > This patch fixes it.
>> >
>> 
>> Tested on... ?
>
> Tested on 3430SDP and 4430SDP.

Please update changelog accordingly.

>> > Signed-off-by: Charulatha V <charu@ti.com>
>> ---
>
> [...]
>
>> > @@ -1570,9 +1603,14 @@ static int gpio_is_input(struct gpio_bank *bank, int mask)
>> >               reg += OMAP7XX_GPIO_DIR_CONTROL;
>> >               break;
>> >       case METHOD_GPIO_24XX:
>> > -     case METHOD_GPIO_44XX:
>> >               reg += OMAP24XX_GPIO_OE;
>> >               break;
>> > +     case METHOD_GPIO_44XX:
>> > +             reg += OMAP4_GPIO_OE;
>> > +             break;
>> > +     default:
>> > +             WARN_ON(1);
>> > +             return -EINVAL;
>> 
>> If you add a WARN, please add a helpful string.
>
> Added this WARN in the same way as in other functions 
> of the same file.

That still doesn't make it helpful.

Repeating an error does not make it correct.

Kevin