From: Kevin Hilman <khilman@deeprootsystems.com>
To: Peter 'p2' De Schrijver <peter.de-schrijver@nokia.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 0/1] OMAP3 PM Add C0 state
Date: Mon, 23 Feb 2009 10:24:24 -0800 [thread overview]
Message-ID: <87ljrx9fl3.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1234974118-27446-1-git-send-email-peter.de-schrijver@nokia.com> (Peter De Schrijver's message of "Wed\, 18 Feb 2009 18\:21\:57 +0200")
"Peter 'p2' De Schrijver" <peter.de-schrijver@nokia.com> writes:
> This patch introduces a new C state C0 which keeps both core and mpu
> powerdomains in ON state. This gives us low latency at a cost of higher
> power consumption.
>
I don't like the name 'C0' for an idle-state. In ACPI terms, C0 is an
active state, not an idle state. I know this is not an ACPI system,
but since we're using ACPI names, we should be consistent.
Is there a real benefit to having an additional state here? Shouldn't
we just make these changes or C1?
Also, for a single patch, can you include the description in the patch
itself instead of the 'PATCH 0/1'. Thanks.
Kevin
next prev parent reply other threads:[~2009-02-23 18:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-18 16:21 [PATCH 0/1] OMAP3 PM Add C0 state Peter 'p2' De Schrijver
2009-02-18 16:21 ` [PATCH 1/1] " Peter 'p2' De Schrijver
2009-02-23 18:24 ` Kevin Hilman [this message]
2009-02-24 10:27 ` [PATCH 0/1] " Peter 'p2' De Schrijver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ljrx9fl3.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=peter.de-schrijver@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox