From: Felipe Balbi <balbi@kernel.org>
To: gregkh@linuxfoundation.org, kgene@kernel.org, krzk@kernel.org,
javier@osg.samsung.com
Cc: Shuah Khan <shuahkh@osg.samsung.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/7] usb: dwc3: core: fix dwc3_probe() to not do put_sync when get_sync fails
Date: Sat, 25 Mar 2017 09:52:29 +0200 [thread overview]
Message-ID: <87mvc923pe.fsf@linux.intel.com> (raw)
In-Reply-To: <2238ea52423a83118ab724a96e8f0691ec4ada0b.1490387086.git.shuahkh@osg.samsung.com>
Hi,
Shuah Khan <shuahkh@osg.samsung.com> writes:
> dwc3_probe() does pm_runtime_put_sync() in its err1 handling when
> pm_runtime_get_sync() fails. Move the pm_runtime_put_sync() under
> err2 instead as it is used in error paths after pm_runtime_get_sync()
> succeeds.
there's nothing wrong with current code. Read the docs. Even if
pm_runtime_get*() fails, you still need to decrement the usage
counter. pm_runtime_put*() is one way of achieving so.
--
balbi
next prev parent reply other threads:[~2017-03-25 7:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-25 0:04 [PATCH 0/7] dwc3 - bug fixes and use meaningful goto labels Shuah Khan
2017-03-25 0:04 ` [PATCH 1/7] usb: dwc3: core: fix dwc3_probe() to not do put_sync when get_sync fails Shuah Khan
2017-03-25 7:52 ` Felipe Balbi [this message]
2017-03-25 0:05 ` [PATCH 2/7] usb: dwc3: dwc3-omap: fix dwc3_omap_probe() do put_sync when get_sync works Shuah Khan
[not found] ` <a7d3539cdb21ef9694869f97a357ce40ace0ddd3.1490387086.git.shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2017-03-25 7:53 ` Felipe Balbi
2017-03-25 0:05 ` [PATCH 3/7] usb: dwc3: core: change goto labels to meaningful names Shuah Khan
[not found] ` <cover.1490387086.git.shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2017-03-25 0:05 ` [PATCH 4/7] usb: dwc3: exynos: change goto labels in this file " Shuah Khan
2017-03-25 0:05 ` [PATCH 5/7] usb: dwc3: omap: " Shuah Khan
2017-03-25 0:05 ` [PATCH 7/7] usb: dwc3: host: " Shuah Khan
2017-03-25 0:05 ` [PATCH 6/7] usb: dwc3: gadget: " Shuah Khan
2017-03-25 7:51 ` [PATCH 0/7] dwc3 - bug fixes and use meaningful goto labels Felipe Balbi
2017-03-27 13:44 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvc923pe.fsf@linux.intel.com \
--to=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=javier@osg.samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=shuahkh@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).