From: Felipe Balbi <balbi@kernel.org>
To: Roger Quadros <rogerq@ti.com>,
Grygorii Strashko <grygorii.strashko@ti.com>
Cc: tony@atomide.com, Joao.Pinto@synopsys.com,
sergei.shtylyov@cogentembedded.com, peter.chen@freescale.com,
jun.li@freescale.com, yoshihiro.shimoda.uh@renesas.com,
nsekhar@ti.com, b-liu@ti.com, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 5/5] usb: dwc3: core: cleanup IRQ resources
Date: Fri, 10 Jun 2016 11:11:27 +0300 [thread overview]
Message-ID: <87mvmt79ao.fsf@linux.intel.com> (raw)
In-Reply-To: <575A7407.1090403@ti.com>
[-- Attachment #1: Type: text/plain, Size: 738 bytes --]
Hi,
Roger Quadros <rogerq@ti.com> writes:
>> Is it expected to have more than one IRQ here?
>>
>> if not - it will better to use platform_get_irq[_byname]().
>>
>
> The reason I used platform_get_resource variant is that i'm passing the
> resource directly to the XHCI platform device below.
>>
>>> +
>>> + dwc->xhci_resources[1].start = res->start;
>>> + dwc->xhci_resources[1].end = res->end;
>>> + dwc->xhci_resources[1].flags = res->flags;
>>> + dwc->xhci_resources[1].name = res->name;
>
> This could just change to
>
> dwc->xhci_resource[1] = *res;
no, it cannot. Look at the definition of struct resource and how it's
used, then you'll see we don't want to copy everything.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2016-06-10 8:11 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 14:36 [PATCH v8 0/5] dwc3: omap: fixes and dual-role preparation Roger Quadros
2016-05-11 14:36 ` [PATCH v8 1/5] usb: dwc3: omap: use request_threaded_irq() Roger Quadros
2016-05-11 14:36 ` [PATCH v8 2/5] usb: dwc3: omap: Mark the interrupt handler as shared Roger Quadros
2016-05-11 14:36 ` [PATCH v8 3/5] usb: dwc3: omap: Don't set POWERPRESENT Roger Quadros
2016-05-11 14:36 ` [PATCH v8 4/5] usb: dwc3: omap: Pass VBUS and ID events transparently Roger Quadros
2016-05-11 14:36 ` [PATCH v8 5/5] usb: dwc3: core: cleanup IRQ resources Roger Quadros
2016-05-24 9:35 ` Felipe Balbi
2016-05-24 12:35 ` Roger Quadros
2016-06-01 7:46 ` [PATCH v9 " Roger Quadros
2016-06-01 8:06 ` Felipe Balbi
2016-06-07 9:28 ` Roger Quadros
2016-06-02 11:52 ` Grygorii Strashko
2016-06-07 9:34 ` Roger Quadros
[not found] ` <57569543.4090007-l0cyMroinI0@public.gmane.org>
2016-06-07 11:49 ` Grygorii Strashko
2016-06-07 12:44 ` Roger Quadros
2016-06-07 13:09 ` Felipe Balbi
[not found] ` <877fe1b0xx.fsf-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-06-07 14:05 ` Roger Quadros
2016-06-10 7:56 ` Roger Quadros
[not found] ` <57501E0D.4010007-l0cyMroinI0@public.gmane.org>
2016-06-10 8:02 ` Roger Quadros
2016-06-10 8:04 ` Roger Quadros
2016-06-10 8:18 ` Felipe Balbi
2016-06-10 8:32 ` Roger Quadros
2016-06-10 9:18 ` Felipe Balbi
2016-06-10 8:11 ` Felipe Balbi [this message]
2016-06-10 9:56 ` [PATCH v10 " Roger Quadros
2016-06-10 10:39 ` Sergei Shtylyov
2016-06-10 11:35 ` Roger Quadros
2016-06-10 11:44 ` Sergei Shtylyov
2016-06-10 11:46 ` Roger Quadros
2016-06-10 12:22 ` Sergei Shtylyov
2016-06-10 11:48 ` [PATCH v11 " Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvmt79ao.fsf@linux.intel.com \
--to=balbi@kernel.org \
--cc=Joao.Pinto@synopsys.com \
--cc=b-liu@ti.com \
--cc=grygorii.strashko@ti.com \
--cc=jun.li@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=peter.chen@freescale.com \
--cc=rogerq@ti.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tony@atomide.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).