From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 1/9] ARM: OMAP4+: Use common scratchpad SAR RAM offsets for all architectures Date: Wed, 27 Mar 2013 11:41:54 -0700 Message-ID: <87mwto7ki5.fsf@linaro.org> References: <1361373527-21695-1-git-send-email-santosh.shilimkar@ti.com> <1361373527-21695-2-git-send-email-santosh.shilimkar@ti.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from mail-pb0-f45.google.com ([209.85.160.45]:51903 "EHLO mail-pb0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752639Ab3C0Sl6 (ORCPT ); Wed, 27 Mar 2013 14:41:58 -0400 Received: by mail-pb0-f45.google.com with SMTP id ro8so5405019pbb.18 for ; Wed, 27 Mar 2013 11:41:57 -0700 (PDT) In-Reply-To: <1361373527-21695-2-git-send-email-santosh.shilimkar@ti.com> (Santosh Shilimkar's message of "Wed, 20 Feb 2013 20:48:39 +0530") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Santosh Shilimkar Cc: linux-omap@vger.kernel.org, tony@atomide.com, linux-arm-kernel@lists.infradead.org, Tero Kristo Santosh Shilimkar writes: > From: Tero Kristo > > Simplifies code and also allows the re-use as is on OMAP5 devices. nit: changelog here is rather weak. It claims "simplifies code" but it's not obvious from the patch how changing a few #defines does that. Kevin > Signed-off-by: Tero Kristo > Signed-off-by: Santosh Shilimkar > --- > arch/arm/mach-omap2/omap4-sar-layout.h | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/arch/arm/mach-omap2/omap4-sar-layout.h b/arch/arm/mach-omap2/omap4-sar-layout.h > index e170fe8..6822d0a 100644 > --- a/arch/arm/mach-omap2/omap4-sar-layout.h > +++ b/arch/arm/mach-omap2/omap4-sar-layout.h > @@ -20,13 +20,13 @@ > #define SAR_BANK4_OFFSET 0x3000 > > /* Scratch pad memory offsets from SAR_BANK1 */ > -#define SCU_OFFSET0 0xd00 > -#define SCU_OFFSET1 0xd04 > -#define OMAP_TYPE_OFFSET 0xd10 > -#define L2X0_SAVE_OFFSET0 0xd14 > -#define L2X0_SAVE_OFFSET1 0xd18 > -#define L2X0_AUXCTRL_OFFSET 0xd1c > -#define L2X0_PREFETCH_CTRL_OFFSET 0xd20 > +#define SCU_OFFSET0 0xfe4 > +#define SCU_OFFSET1 0xfe8 > +#define OMAP_TYPE_OFFSET 0xfec > +#define L2X0_SAVE_OFFSET0 0xff0 > +#define L2X0_SAVE_OFFSET1 0xff4 > +#define L2X0_AUXCTRL_OFFSET 0xff8 > +#define L2X0_PREFETCH_CTRL_OFFSET 0xffc > > /* CPUx Wakeup Non-Secure Physical Address offsets in SAR_BANK3 */ > #define CPU0_WAKEUP_NS_PA_ADDR_OFFSET 0xa04