From: Kevin Hilman <khilman@deeprootsystems.com>
To: "Hiremath, Vaibhav" <hvaibhav@ti.com>
Cc: Joel A Fernandes <agnel.joel@gmail.com>,
Igor Mazanov <i.mazanov@gmail.com>,
Tony Lindgren <tony@atomide.com>,
Jean Pihet <jean.pihet@newoldbits.com>,
"Menon, Nishanth" <nm@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: AM335x: Beaglebone stops to boot with current git kernel
Date: Mon, 03 Dec 2012 10:19:36 -0800 [thread overview]
Message-ID: <87mwxvathj.fsf@deeprootsystems.com> (raw)
In-Reply-To: <79CD15C6BA57404B839C016229A409A83EB7FB16@DBDE01.ent.ti.com> (Vaibhav Hiremath's message of "Fri, 23 Nov 2012 06:04:03 +0000")
"Hiremath, Vaibhav" <hvaibhav@ti.com> writes:
>> >>> +static struct omap_hwmod am33xx_debugss_hwmod = {
>> >>> + .name = "debugss",
>> >>> + .class = &am33xx_debugss_hwmod_class,
>> >>> + .clkdm_name = "l3_aon_clkdm",
>> >>> + .main_clk = "debugss_ick",
>> >>> + .flags = (HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET),
>>
>> Setting these flags would still leave the problem where JTAG clocks
>> are on when its not required no? In that case, what is the advantage
>> of this patch?
>>
>
> I missed to wrap it around #ifdef CONFIG_DEBUG_KERNEL. I will submit the
> formal patch shortly.
IMO, this should not be handled in the data at all (neither clock nor
hwmod), and should be handled at runtime/boot-time, not compile time.
The solution to this is to rather to have a small bit of code that
requests the debugss clocks that are needed for JTAG debug, so the
kernel knows they are in use.
That code could then be enabled at boot time via command-line or DT
option.
Kevin
next prev parent reply other threads:[~2012-12-03 18:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-14 15:28 AM335x: Beaglebone stops to boot with current git kernel Igor Mazanov
2012-11-14 16:41 ` Jean Pihet
2012-11-14 16:54 ` Nishanth Menon
2012-11-14 17:51 ` Tony Lindgren
2012-11-15 14:47 ` Jean Pihet
2012-11-15 16:27 ` Tony Lindgren
2012-11-21 18:38 ` Tony Lindgren
2012-11-21 20:00 ` Igor Mazanov
2012-11-22 5:42 ` Vaibhav Hiremath
2012-11-22 12:16 ` Igor Mazanov
2012-11-22 14:47 ` Hiremath, Vaibhav
2012-11-22 14:49 ` Hiremath, Vaibhav
2012-11-22 16:40 ` Igor Mazanov
2012-11-22 20:56 ` Joel A Fernandes
2012-11-23 6:04 ` Hiremath, Vaibhav
2012-12-03 18:19 ` Kevin Hilman [this message]
2012-12-04 4:01 ` Hiremath, Vaibhav
2012-12-04 4:11 ` Joel A Fernandes
2012-12-04 21:39 ` Kevin Hilman
2012-11-23 6:08 ` Hiremath, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwxvathj.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=agnel.joel@gmail.com \
--cc=hvaibhav@ti.com \
--cc=i.mazanov@gmail.com \
--cc=jean.pihet@newoldbits.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox