From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCHv2 04/19] ARM: OMAP4: PM: save/restore all DPLL settings in OFF mode Date: Thu, 17 May 2012 09:37:42 -0700 Message-ID: <87mx56227d.fsf@ti.com> References: <1336990730-26892-1-git-send-email-t-kristo@ti.com> <1336990730-26892-5-git-send-email-t-kristo@ti.com> <87d363928g.fsf@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from na3sys009aog109.obsmtp.com ([74.125.149.201]:54391 "EHLO na3sys009aog109.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932751Ab2EQQht convert rfc822-to-8bit (ORCPT ); Thu, 17 May 2012 12:37:49 -0400 Received: by pbbrq13 with SMTP id rq13so3196369pbb.22 for ; Thu, 17 May 2012 09:37:47 -0700 (PDT) In-Reply-To: (Santosh Shilimkar's message of "Thu, 17 May 2012 14:22:52 +0530") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Shilimkar, Santosh" Cc: Tero Kristo , linux-omap@vger.kernel.org, paul@pwsan.com, linux-arm-kernel@lists.infradead.org, Rajendra Nayak , Nishanth Menon "Shilimkar, Santosh" writes: > On Thu, May 17, 2012 at 12:34 PM, Shilimkar, Santosh > wrote: >> On Thu, May 17, 2012 at 4:12 AM, Kevin Hilman wrote= : >>> Tero Kristo writes: >>> >>>> From: Rajendra Nayak >>>> >>>> SAR/ROM code restores only CORE DPLL to its original state >>>> post wakeup from OFF mode. >>>> The rest of the DPLL's in OMAP4 platform (MPU/IVA/ABE/USB/PER) >>>> are saved and restored here during an OFF transition. >>>> >>>> [nm@ti.com: minor cleanups] >>>> Signed-off-by: Nishanth Menon >>>> Signed-off-by: Rajendra Nayak >>>> Signed-off-by: Santosh Shilimkar >>>> Signed-off-by: Tero Kristo >>> >>> Some general comments: >>> >>> - the register dump/print doesn't belong here. =C2=A0If needed, sho= uld be a >>> =C2=A0debug feature if needed. >>> >>> - Rather than hooking into omap4_enter_lowpower(), should use >>> =C2=A0the cluster PM enter/exit notifier chain. >>> >> This is again specific to device OFF only and not related to CPU >> cluster state as such. So I don't think notifiers should be used her= e. >> >> O.w even when we attempt just MPU OSWR C-state, all these functions = will >> get called in notifier chain. >> > Just a thought, we can have a separate notifier chain for device OFF.= It can > allow use to get rid of 'enable_off_mode" kind of flags and can be > used by many drivers too. Yes, I like this idea. It allows a much cleaner collection of all the activities needed for device off. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html