From: Kevin Hilman <khilman@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Tero Kristo <t-kristo@ti.com>, Rajendra Nayak <rnayak@ti.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>
Subject: Re: [PATCH 1/2] ARM: OMAP3: PM: remove superfluous calls to pwrdm_clear_all_prev_pwrst()
Date: Tue, 31 Jan 2012 09:29:13 -0800 [thread overview]
Message-ID: <87mx93ok5y.fsf@ti.com> (raw)
In-Reply-To: <878vkopw2o.fsf@ti.com> (Kevin Hilman's message of "Mon, 30 Jan 2012 16:14:23 -0800")
Paul,
Kevin Hilman <khilman@ti.com> writes:
> Paul Walmsley <paul@pwsan.com> writes:
>
>> Remove some superfluous calls to pwrdm_clear_all_prev_pwrst().
>> pwrdm_pre_transition(), which appears a few lines after these calls,
>> invokes pwrdm_clear_all_prev_pwrst() on each powerdomain -- there's no
>> need to do it twice.
>
> It looks like these two for OMAP4 are surpurfluous since the immediately
> follow a call to pwrdm_pre_transition() as well.
>
> Santosh/Rajendra, please confirm/ack.
So after the discussion, do you want to fold this into the original
patch, or do you want a separate patch?
Kevin
next prev parent reply other threads:[~2012-01-31 17:29 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 9:43 [PATCH 0/2] ARM: OMAP2+: PM: miscellaneous powerdomain-related improvements Paul Walmsley
2012-01-30 9:43 ` [PATCH 1/2] ARM: OMAP3: PM: remove superfluous calls to pwrdm_clear_all_prev_pwrst() Paul Walmsley
2012-01-30 10:54 ` Shilimkar, Santosh
2012-01-31 0:14 ` Kevin Hilman
2012-01-31 3:53 ` Rajendra Nayak
2012-01-31 6:57 ` Shilimkar, Santosh
2012-01-31 7:15 ` Paul Walmsley
2012-01-31 7:23 ` Shilimkar, Santosh
2012-01-31 7:27 ` Paul Walmsley
2012-01-31 7:34 ` Shilimkar, Santosh
2012-01-31 7:49 ` Paul Walmsley
2012-01-31 8:37 ` Shilimkar, Santosh
2012-01-31 17:29 ` Kevin Hilman [this message]
2012-02-01 19:27 ` Paul Walmsley
2012-02-02 7:13 ` Shilimkar, Santosh
2012-02-02 8:33 ` Paul Walmsley
2012-02-02 8:59 ` Shilimkar, Santosh
2012-02-02 10:05 ` Paul Walmsley
2012-02-02 10:17 ` Shilimkar, Santosh
2012-02-02 15:24 ` Shilimkar, Santosh
2012-02-02 19:59 ` Paul Walmsley
2012-02-02 18:14 ` Kevin Hilman
2012-01-30 9:43 ` [PATCH 2/2] ARM: OMAP2+: PM: clean up omap_set_pwrdm_state() Paul Walmsley
2012-01-30 12:17 ` Shilimkar, Santosh
2012-01-31 3:46 ` Rajendra Nayak
2012-01-30 21:27 ` [PATCH 0/2] ARM: OMAP2+: PM: miscellaneous powerdomain-related improvements Kevin Hilman
2012-01-31 7:21 ` Tero Kristo
2012-02-01 13:55 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mx93ok5y.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox