From: Kevin Hilman <khilman@ti.com>
To: Shubhrajyoti <shubhrajyoti@ti.com>
Cc: linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4] OMAP4: hwmod data: I2C: add flag for context restore
Date: Wed, 24 Aug 2011 07:44:09 -0700 [thread overview]
Message-ID: <87mxeyg98m.fsf@ti.com> (raw)
In-Reply-To: <4E54D012.6050708@ti.com> (shubhrajyoti@ti.com's message of "Wed, 24 Aug 2011 15:48:58 +0530")
Shubhrajyoti <shubhrajyoti@ti.com> writes:
> On Sunday 17 July 2011 06:13 PM, Shubhrajyoti D wrote:
>> Restore of context is not done for OMAP4. This patch
>> adds the OMAP_I2C_FLAG_RESET_REGS_POSTIDLE in the OMAP4
>> hwmod data which activates the restore for OMAP4.
>> Currently the OMAP4 does not hit device off still the
>> driver may have support for it.
> Could this patch be queued as well?
Paul is the maintainer for the hwmod data. It is usually helpful to
ensure the maintainer is specifically added to the To line.
Kevin
>> Reviewed-by: Kevin Hilman<khilman@ti.com>
>> Signed-off-by: Shubhrajyoti D<shubhrajyoti@ti.com>
>> ---
>> Applies on top of patches from Andy Green
>> http://www.spinics.net/lists/linux-i2c/msg05632.html
>> Tested on OMAP4430
>>
>> arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
>> index 0fe9556..5e2c748 100644
>> --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
>> +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
>> @@ -2130,7 +2130,8 @@ static struct omap_hwmod_class omap44xx_i2c_hwmod_class = {
>> };
>>
>> static struct omap_i2c_dev_attr i2c_dev_attr = {
>> - .flags = OMAP_I2C_FLAG_BUS_SHIFT_NONE,
>> + .flags = OMAP_I2C_FLAG_BUS_SHIFT_NONE |
>> + OMAP_I2C_FLAG_RESET_REGS_POSTIDLE,
>> };
>>
>> /* i2c1 */
next prev parent reply other threads:[~2011-08-24 14:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-17 12:43 [PATCH v4] OMAP4: hwmod data: I2C: add flag for context restore Shubhrajyoti D
[not found] ` <1310906603-2673-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2011-08-24 10:18 ` Shubhrajyoti
2011-08-24 14:44 ` Kevin Hilman [this message]
[not found] ` <87mxeyg98m.fsf-l0cyMroinI0@public.gmane.org>
2011-08-25 12:22 ` Shubhrajyoti
-- strict thread matches above, loose matches on Subject: below --
2011-07-15 6:01 Shubhrajyoti D
[not found] ` <1310709714-3295-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2011-07-15 21:55 ` Kevin Hilman
[not found] ` <871uxrnr92.fsf-l0cyMroinI0@public.gmane.org>
2011-07-17 15:33 ` Shubhrajyoti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mxeyg98m.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=shubhrajyoti@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox