From: Kevin Hilman <khilman@ti.com>
To: Kishore Kadiyala <kishore.kadiyala@ti.com>
Cc: linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org,
tony@atomide.com, cjb@laptop.org, madhu.cr@ti.com,
paul@pwsan.com, Rajendra Nayak <rnayak@ti.com>
Subject: Re: [PATCH 3/5] OMAP3: hwmod data: Add HSMMC
Date: Tue, 08 Feb 2011 14:30:34 -0800 [thread overview]
Message-ID: <87mxm6jh11.fsf@ti.com> (raw)
In-Reply-To: <1296660462-28489-4-git-send-email-kishore.kadiyala@ti.com> (Kishore Kadiyala's message of "Wed, 2 Feb 2011 20:57:40 +0530")
Kishore Kadiyala <kishore.kadiyala@ti.com> writes:
> From: Paul Walmsley <paul@pwsan.com>
>
> Update the omap3 hwmod data with the HSMMC info.
>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
> Signed-off-by: Kishore Kadiyala <kishore.kadiyala@ti.com>
[...]
Just notcied a minor issue below, which was probably inherited from my
original hacks on this code...
> +static struct omap_hwmod omap3xxx_mmc1_hwmod = {
> + .name = "mmc1_hwmod",
> + .mpu_irqs = mmc1_mpu_irqs,
> + .mpu_irqs_cnt = ARRAY_SIZE(mmc1_mpu_irqs),
> + .sdma_reqs = mmc1_sdma_reqs,
> + .sdma_reqs_cnt = ARRAY_SIZE(mmc1_sdma_reqs),
> + .opt_clks = mmc1_opt_clks,
> + .opt_clks_cnt = ARRAY_SIZE(mmc1_opt_clks),
> + .main_clk = "mmchs1_fck",
> + .prcm = {
> + .omap2 = {
> + .module_offs = CORE_MOD,
> + .prcm_reg_id = 1,
> + .module_bit = OMAP3430_GRPSEL_MMC1_SHIFT,
Thee GRPSEL bit isn't the right bit here, and should be the
EN_MMC1_SHIFT value. I realize, they're probably the same bitfield, but
this should be consistent with the other hwmods.
Same issue with other MMC hwmods.
Kevin
next prev parent reply other threads:[~2011-02-08 22:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-02 15:27 [PATCH 0/5] OMAP: HSMMC: hwmod adaptation Kishore Kadiyala
2011-02-02 15:27 ` [PATCH 1/5] OMAP2420: hwmod data: Add HSMMC Kishore Kadiyala
2011-02-08 22:36 ` Kevin Hilman
2011-02-10 17:02 ` Kadiyala, Kishore
2011-02-08 23:29 ` Paul Walmsley
2011-02-10 17:07 ` Kadiyala, Kishore
2011-02-10 19:52 ` Paul Walmsley
2011-02-02 15:27 ` [PATCH 2/5] OMAP2430: " Kishore Kadiyala
2011-02-02 15:27 ` [PATCH 3/5] OMAP3: " Kishore Kadiyala
2011-02-08 22:30 ` Kevin Hilman [this message]
2011-02-10 17:02 ` Kadiyala, Kishore
2011-02-02 15:27 ` [PATCH 4/5] OMAP4: " Kishore Kadiyala
2011-02-02 15:27 ` [PATCH 5/5] OMAP: devices: Modify HSMMC device to adapt to hwmod framework Kishore Kadiyala
2011-02-08 23:05 ` Kevin Hilman
2011-02-10 17:08 ` Kadiyala, Kishore
2011-02-10 21:10 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mxm6jh11.fsf@ti.com \
--to=khilman@ti.com \
--cc=cjb@laptop.org \
--cc=kishore.kadiyala@ti.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=madhu.cr@ti.com \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).