linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] OMAP: PM: CPUFREQ: Fix conditional compilation
@ 2010-09-29  9:22 Silesh C V
  2010-09-29 22:28 ` Kevin Hilman
  0 siblings, 1 reply; 2+ messages in thread
From: Silesh C V @ 2010-09-29  9:22 UTC (permalink / raw)
  To: linux-omap; +Cc: khilman, Silesh C V

Fix conditional compilation. A conditional expresiion
should follow "#elif", in this case #elif clause should
check whether CONFIG_ARCH_OMAP3 is defined or not
(ie. defined(CONFIG_ARCH_OMAP3)) rather than checking for
the value of the macro.

Signed-off-by: Silesh C V <silesh@ti.com>
---
 arch/arm/plat-omap/cpu-omap.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/plat-omap/cpu-omap.c b/arch/arm/plat-omap/cpu-omap.c
index df08829..02e4865 100644
--- a/arch/arm/plat-omap/cpu-omap.c
+++ b/arch/arm/plat-omap/cpu-omap.c
@@ -41,7 +41,7 @@ static struct cpufreq_frequency_table *freq_table;
 
 #ifdef CONFIG_ARCH_OMAP1
 #define MPU_CLK		"mpu"
-#elif CONFIG_ARCH_OMAP3
+#elif defined(CONFIG_ARCH_OMAP3)
 #define MPU_CLK		"arm_fck"
 #else
 #define MPU_CLK		"virt_prcm_set"
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] OMAP: PM: CPUFREQ: Fix conditional compilation
  2010-09-29  9:22 [PATCH v2] OMAP: PM: CPUFREQ: Fix conditional compilation Silesh C V
@ 2010-09-29 22:28 ` Kevin Hilman
  0 siblings, 0 replies; 2+ messages in thread
From: Kevin Hilman @ 2010-09-29 22:28 UTC (permalink / raw)
  To: Silesh C V; +Cc: linux-omap

Silesh C V <silesh@ti.com> writes:

> Fix conditional compilation. A conditional expresiion
> should follow "#elif", in this case #elif clause should
> check whether CONFIG_ARCH_OMAP3 is defined or not
> (ie. defined(CONFIG_ARCH_OMAP3)) rather than checking for
> the value of the macro.
>
> Signed-off-by: Silesh C V <silesh@ti.com>

OK, applied to the pm-cpufreq sub-branch of the PM branch.

Kevin

> ---
>  arch/arm/plat-omap/cpu-omap.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-omap/cpu-omap.c b/arch/arm/plat-omap/cpu-omap.c
> index df08829..02e4865 100644
> --- a/arch/arm/plat-omap/cpu-omap.c
> +++ b/arch/arm/plat-omap/cpu-omap.c
> @@ -41,7 +41,7 @@ static struct cpufreq_frequency_table *freq_table;
>  
>  #ifdef CONFIG_ARCH_OMAP1
>  #define MPU_CLK		"mpu"
> -#elif CONFIG_ARCH_OMAP3
> +#elif defined(CONFIG_ARCH_OMAP3)
>  #define MPU_CLK		"arm_fck"
>  #else
>  #define MPU_CLK		"virt_prcm_set"

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-09-29 22:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-29  9:22 [PATCH v2] OMAP: PM: CPUFREQ: Fix conditional compilation Silesh C V
2010-09-29 22:28 ` Kevin Hilman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).