Re: [PATCH] OMAP: DSS: ensure clocks are disabled on failed init

[Kevin Hilman <khilman@deeprootsystems.com>]

Tomi Valkeinen <tomi.valkeinen@nokia.com> writes:

> Hi,
>
> On Tue, 2010-04-27 at 11:14 +0200, ext Grazvydas Ignotas wrote:
>> CC Tomi in case he missed this.
>
> Thanks =)
>
>> 
>> On Mon, Apr 26, 2010 at 10:12 PM, Kevin Hilman
>> <khilman@deeprootsystems.com> wrote:
>> > Currently, if init fails for whatever reason, various DSS related
>> > clocks will be left enabled and prevent the chip from hitting
>> > retention or off-mode.
>> >
>> > This patch ensures the clocks are disabled on a failed init.
>> >
>> > For this to work, a check had to be added to dispc_save_context()
>> > to not save context if it has not yet been initialized.
>
> The code in omap_dss_probe() is actually quite broken, as the /* XXX
> fail correctly */ hints... At least clocks should be put(), debugfs
> should be uninitialized etc. So this patch is ok quick fix, but I'll try
> to find time to fix the fail path properly.

Thanks.  My main concern of course is that any failed init will ensure
clocks are disabled and the modules are able to idle.

Kevin