From: Kevin Hilman <khilman@deeprootsystems.com>
To: "Pandita, Vikram" <vikram.pandita@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
Hugo Vincent <hugo.vincent@gmail.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Chikkature Rajashekar, Madhusudhan" <madhu.cr@ti.com>
Subject: Re: [PATCH] OMAP3: MMC: Add mux for pins
Date: Wed, 17 Jun 2009 11:27:50 -0700 [thread overview]
Message-ID: <87my86yau1.fsf@deeprootsystems.com> (raw)
In-Reply-To: <FCCFB4CDC6E5564B9182F639FC35608702F53D18B1@dbde02.ent.ti.com> (Vikram Pandita's message of "Wed\, 17 Jun 2009 23\:14\:58 +0530")
"Pandita, Vikram" <vikram.pandita@ti.com> writes:
>>
>>If some pins are always needed, and don't have alternative pinouts, then
>>the common pins could be muxed in devices.c.
>
> This is the algo we can use for MMC pin muxing in that case:
>
> MMC1: No pin has mux clash
> Mux all 10 pins in devices.c
Is this common across 34xx and 35xx?
> MMC2: MUX CLK,CMD,D0-D3 in devices.c: D4-D7 have mux clash
> In case board needs 8 bit support,
> then in devices.c print KERN_WARNING "Configure MMC2:D4-D7 mux in board file"
I don't think you need a KERN_WARNING, what if the board code does this
later? Probably a comment in the code would suffice.
> MMC3: All pins have mux clash: No mux done in devices.c
> In case board specifies MMC3 usage,
> then in devices.c print KERN_WARNING "Configure MMC3 mux in board file"
>
> Let me know if this is final and I can submit a patch.
Kevin
next prev parent reply other threads:[~2009-06-17 18:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-12 22:41 [PATCH] OMAP3: MMC: Add mux for pins Vikram Pandita
2009-06-15 8:12 ` Tony Lindgren
2009-06-15 10:44 ` Hugo Vincent
2009-06-15 11:04 ` Tony Lindgren
2009-06-15 15:46 ` Madhusudhan
2009-06-16 14:56 ` Pandita, Vikram
2009-06-16 15:35 ` Kevin Hilman
2009-06-16 16:50 ` Pandita, Vikram
2009-06-17 8:12 ` Tony Lindgren
2009-06-17 17:44 ` Pandita, Vikram
2009-06-17 18:27 ` Kevin Hilman [this message]
2009-06-17 18:38 ` Pandita, Vikram
2009-06-17 21:39 ` Kevin Hilman
2009-06-17 22:48 ` Jon Hunter
2009-06-17 22:57 ` Kevin Hilman
2009-06-17 23:25 ` Pandita, Vikram
2009-06-18 0:08 ` Jon Hunter
2009-06-18 5:04 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87my86yau1.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=hugo.vincent@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=madhu.cr@ti.com \
--cc=tony@atomide.com \
--cc=vikram.pandita@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox