[PATCH] OMAP:clock: missing list_del for clk_notifier_unregister

[PATCH] OMAP:clock: missing list_del for clk_notifier_unregister

[Nishanth Menon]

>From b30537e692ac7e72858479327935b16813ea3f56 Mon Sep 17 00:00:00 2001
From: Nishanth Menon <nm@ti.com>
Date: Wed, 11 Mar 2009 11:29:11 -0500
Subject: [PATCH] OMAP:clock: missing list_del for clk_notifier_unregister

Apologies on the spam.. looks like my git-send-email needs a bit more
tweaking :(.. sending from gmail..

clk_notifier_unregister should clean the list before
freeing clock notifier, else clk_notifier_list is
filled with dangling pointers

Issue seen while repetative loading/unloading of bridgedriver

Ref: http://marc.info/?t=123678326300002&r=1&w=2

Signed-off-by: Nishanth Menon <nm@ti.com>
---
 arch/arm/plat-omap/clock.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/arch/arm/plat-omap/clock.c b/arch/arm/plat-omap/clock.c
index c8d9e96..523d1b0 100644
--- a/arch/arm/plat-omap/clock.c
+++ b/arch/arm/plat-omap/clock.c
@@ -725,8 +725,11 @@ int clk_notifier_unregister(struct clk *clk, struct
notifier_block *nb)
          * XXX ugh, layering violation.  there should be some
          * support in the notifier code for this.
          */
-        if (!cn->notifier_head.head)
+        if (!cn->notifier_head.head) {
+            /* Free up my clock node too */
+            list_del(&cn->node);
             kfree(cn);
+        }
 
     } else {
         r = -ENOENT;
-- 
1.5.4.3

Re: [PATCH] OMAP:clock: missing list_del for clk_notifier_unregister

[Paul Walmsley]

Hi,

On Wed, 11 Mar 2009, Nishanth Menon wrote:

> clk_notifier_unregister should clean the list before
> freeing clock notifier, else clk_notifier_list is
> filled with dangling pointers
> 
> Issue seen while repetative loading/unloading of bridgedriver
> 
> Ref: http://marc.info/?t=123678326300002&r=1&w=2
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>  arch/arm/plat-omap/clock.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/plat-omap/clock.c b/arch/arm/plat-omap/clock.c
> index c8d9e96..523d1b0 100644
> --- a/arch/arm/plat-omap/clock.c
> +++ b/arch/arm/plat-omap/clock.c
> @@ -725,8 +725,11 @@ int clk_notifier_unregister(struct clk *clk, struct notifier_block *nb)
>  		 * XXX ugh, layering violation.  there should be some
>  		 * support in the notifier code for this.
>  		 */
> -		if (!cn->notifier_head.head)
> +		if (!cn->notifier_head.head) {
> +			/* Free up my clock node too */
> +			list_del(&cn->node);
>  			kfree(cn);
> +		}
>  
>  	} else {
>  		r = -ENOENT;
> -- 
> 1.5.4.3
> 

Thanks, this looks good.

Just to clarify, this is currently against the PM branch.  There's a new 
version of the clock notifier patch coming out soon against l-o; will roll 
this fix in.


- Paul

RE: [PATCH] OMAP:clock: missing list_del for clk_notifier_unregister

[Menon, Nishanth]

> -----Original Message-----
> From: Paul Walmsley [mailto:paul@pwsan.com]
> Sent: Thursday, March 12, 2009 9:31 AM
> To: Menon, Nishanth
> Cc: linux-omap@vger.kernel.org; Woodruff, Richard; Nayak, Rajendra; Gupta,
> Ramesh; Palande Ameya
> Subject: Re: [PATCH] OMAP:clock: missing list_del for
> clk_notifier_unregister
 
> Just to clarify, this is currently against the PM branch.  There's a new
Yes. This is against the PM branch
> version of the clock notifier patch coming out soon against l-o; will roll
> this fix in.
> 
Thanks.
Regards,
Nishanth Menon

Re: [PATCH] OMAP:clock: missing list_del for clk_notifier_unregister

[Kevin Hilman]

"Menon, Nishanth" <nm@ti.com> writes:

>> -----Original Message-----
>> From: Paul Walmsley [mailto:paul@pwsan.com]
>> Sent: Thursday, March 12, 2009 9:31 AM
>> To: Menon, Nishanth
>> Cc: linux-omap@vger.kernel.org; Woodruff, Richard; Nayak, Rajendra; Gupta,
>> Ramesh; Palande Ameya
>> Subject: Re: [PATCH] OMAP:clock: missing list_del for
>> clk_notifier_unregister
>  
>> Just to clarify, this is currently against the PM branch.  There's a new
>
> Yes. This is against the PM branch
>

OK, I'll add this to PM branch...

>> version of the clock notifier patch coming out soon against l-o; will roll
>> this fix in.


And then pull in the new version when it appears.

Kevin