* [PATCH] Don't scale voltage in C1 state
@ 2009-01-14 16:06 Peter 'p2' De Schrijver
0 siblings, 0 replies; 4+ messages in thread
From: Peter 'p2' De Schrijver @ 2009-01-14 16:06 UTC (permalink / raw)
To: linux-omap; +Cc: Peter 'p2' De Schrijver
This patch prevents VDD1 and VDD2 to go to the lowest OPP when entering C1.
It improves wakeup latency from 600us to about 50us.
---
arch/arm/mach-omap2/pm34xx.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
index b0b2188..87ef55e 100644
--- a/arch/arm/mach-omap2/pm34xx.c
+++ b/arch/arm/mach-omap2/pm34xx.c
@@ -1052,7 +1052,7 @@ static void __init configure_vc(void)
OMAP3_PRM_VC_I2C_CFG_OFFSET);
/* Setup voltctrl and other setup times */
- prm_write_mod_reg(OMAP3430_AUTO_RET | OMAP3430_AUTO_SLEEP,
+ prm_write_mod_reg(OMAP3430_AUTO_RET,
OMAP3430_GR_MOD, OMAP3_PRM_VOLTCTRL_OFFSET);
prm_write_mod_reg(OMAP3430_CLKSETUP_DURATION, OMAP3430_GR_MOD,
--
1.5.6.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] Don't scale voltage in C1 state
@ 2009-01-14 16:32 Peter 'p2' De Schrijver
2009-01-14 22:33 ` Kevin Hilman
2009-01-27 22:34 ` Kevin Hilman
0 siblings, 2 replies; 4+ messages in thread
From: Peter 'p2' De Schrijver @ 2009-01-14 16:32 UTC (permalink / raw)
To: linux-omap; +Cc: Peter 'p2' De Schrijver
This patch prevents VDD1 and VDD2 to go to the lowest OPP when entering C1.
It improves wakeup latency from 600us to about 50us.
Now with signoff :)
Signed-off-by: Peter 'p2' De Schrijver <peter.de-schrijver@nokia.com>
---
arch/arm/mach-omap2/pm34xx.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
index b0b2188..87ef55e 100644
--- a/arch/arm/mach-omap2/pm34xx.c
+++ b/arch/arm/mach-omap2/pm34xx.c
@@ -1052,7 +1052,7 @@ static void __init configure_vc(void)
OMAP3_PRM_VC_I2C_CFG_OFFSET);
/* Setup voltctrl and other setup times */
- prm_write_mod_reg(OMAP3430_AUTO_RET | OMAP3430_AUTO_SLEEP,
+ prm_write_mod_reg(OMAP3430_AUTO_RET,
OMAP3430_GR_MOD, OMAP3_PRM_VOLTCTRL_OFFSET);
prm_write_mod_reg(OMAP3430_CLKSETUP_DURATION, OMAP3430_GR_MOD,
--
1.5.6.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Don't scale voltage in C1 state
2009-01-14 16:32 [PATCH] Don't scale voltage in C1 state Peter 'p2' De Schrijver
@ 2009-01-14 22:33 ` Kevin Hilman
2009-01-27 22:34 ` Kevin Hilman
1 sibling, 0 replies; 4+ messages in thread
From: Kevin Hilman @ 2009-01-14 22:33 UTC (permalink / raw)
To: Peter 'p2' De Schrijver; +Cc: linux-omap
"Peter 'p2' De Schrijver" <peter.de-schrijver@nokia.com> writes:
> This patch prevents VDD1 and VDD2 to go to the lowest OPP when entering C1.
> It improves wakeup latency from 600us to about 50us.
>
> Now with signoff :)
>
> Signed-off-by: Peter 'p2' De Schrijver <peter.de-schrijver@nokia.com>
Thanks, pushing to PM branch.
Kevin
> arch/arm/mach-omap2/pm34xx.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
> index b0b2188..87ef55e 100644
> --- a/arch/arm/mach-omap2/pm34xx.c
> +++ b/arch/arm/mach-omap2/pm34xx.c
> @@ -1052,7 +1052,7 @@ static void __init configure_vc(void)
> OMAP3_PRM_VC_I2C_CFG_OFFSET);
>
> /* Setup voltctrl and other setup times */
> - prm_write_mod_reg(OMAP3430_AUTO_RET | OMAP3430_AUTO_SLEEP,
> + prm_write_mod_reg(OMAP3430_AUTO_RET,
> OMAP3430_GR_MOD, OMAP3_PRM_VOLTCTRL_OFFSET);
>
> prm_write_mod_reg(OMAP3430_CLKSETUP_DURATION, OMAP3430_GR_MOD,
> --
> 1.5.6.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Don't scale voltage in C1 state
2009-01-14 16:32 [PATCH] Don't scale voltage in C1 state Peter 'p2' De Schrijver
2009-01-14 22:33 ` Kevin Hilman
@ 2009-01-27 22:34 ` Kevin Hilman
1 sibling, 0 replies; 4+ messages in thread
From: Kevin Hilman @ 2009-01-27 22:34 UTC (permalink / raw)
To: Peter 'p2' De Schrijver; +Cc: linux-omap
"Peter 'p2' De Schrijver" <peter.de-schrijver@nokia.com> writes:
> This patch prevents VDD1 and VDD2 to go to the lowest OPP when entering C1.
> It improves wakeup latency from 600us to about 50us.
>
> Now with signoff :)
>
> Signed-off-by: Peter 'p2' De Schrijver <peter.de-schrijver@nokia.com>
Thanks, pushed to PM branch.
Kevin
> ---
> arch/arm/mach-omap2/pm34xx.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
> index b0b2188..87ef55e 100644
> --- a/arch/arm/mach-omap2/pm34xx.c
> +++ b/arch/arm/mach-omap2/pm34xx.c
> @@ -1052,7 +1052,7 @@ static void __init configure_vc(void)
> OMAP3_PRM_VC_I2C_CFG_OFFSET);
>
> /* Setup voltctrl and other setup times */
> - prm_write_mod_reg(OMAP3430_AUTO_RET | OMAP3430_AUTO_SLEEP,
> + prm_write_mod_reg(OMAP3430_AUTO_RET,
> OMAP3430_GR_MOD, OMAP3_PRM_VOLTCTRL_OFFSET);
>
> prm_write_mod_reg(OMAP3430_CLKSETUP_DURATION, OMAP3430_GR_MOD,
> --
> 1.5.6.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-01-27 22:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-14 16:32 [PATCH] Don't scale voltage in C1 state Peter 'p2' De Schrijver
2009-01-14 22:33 ` Kevin Hilman
2009-01-27 22:34 ` Kevin Hilman
-- strict thread matches above, loose matches on Subject: below --
2009-01-14 16:06 Peter 'p2' De Schrijver
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox