From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 06/10] omap2+: Remove gptimer_wakeup for now Date: Thu, 23 Jun 2011 08:05:07 -0700 Message-ID: <87oc1obnbw.fsf@ti.com> References: <20110620091754.357.56441.stgit@kaulin> <20110620092341.357.14183.stgit@kaulin> <4DFF1558.4020509@ti.com> <20110620094846.GG23145@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aog117.obsmtp.com ([74.125.149.242]:56635 "EHLO na3sys009aog117.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755834Ab1FWPFL (ORCPT ); Thu, 23 Jun 2011 11:05:11 -0400 Received: by mail-pw0-f48.google.com with SMTP id 9so1283086pwj.7 for ; Thu, 23 Jun 2011 08:05:10 -0700 (PDT) In-Reply-To: <20110620094846.GG23145@atomide.com> (Tony Lindgren's message of "Mon, 20 Jun 2011 02:48:46 -0700") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tony Lindgren Cc: Santosh Shilimkar , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org Tony Lindgren writes: > * Santosh Shilimkar [110620 02:35]: >> On 6/20/2011 2:53 PM, Tony Lindgren wrote: >> >This removes the support for setting the wake-up timer for debugging. >> > >> >Later on we can reserve gptimer1 for PM code only and have similar >> >functionality. >> > >> >Signed-off-by: Tony Lindgren >> >Reviewed-by: Kevin Hilman >> >--- >> >> Kevin cleaned up this with a better patch. >> http://www.mail-archive.com/linux-omap@vger.kernel.org/msg50015.html >> >> May be we can use that patch instead of this. > > The thing is that it's a omap specific debug interface. What's wrong with OMAP-specific debug interfaces? We have plenty of them: clock, omap_mux and pm_debug. > I'd rather just get rid of it until there's some generic way > of doing it. Well, we won't have a truly generic way of doing it until we have a generic way of doing HW timers. The implementation is now mostly generic in the patch Santosh referened above in that the timer programming is now done as part of the clockevent code, and not external timer programming. So now, the only thing OMAP-specific is the debugfs file used to trigger it. > Maybe Kevin can just carry it along in the PM branch for now? I'd prefer to keep it in mainline as this is a very important feature for the PM functionality already in mainline. Kevin