From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 1/5] OMAP3 cpuidle: remove useless SDP specific timings Date: Wed, 04 May 2011 07:40:01 -0700 Message-ID: <87oc3iv8am.fsf@ti.com> References: <1304069186-3086-1-git-send-email-j-pihet@ti.com> <1304069186-3086-2-git-send-email-j-pihet@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aog110.obsmtp.com ([74.125.149.203]:58442 "EHLO na3sys009aog110.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754270Ab1EDOkG (ORCPT ); Wed, 4 May 2011 10:40:06 -0400 Received: by mail-pw0-f46.google.com with SMTP id 15so541697pwi.19 for ; Wed, 04 May 2011 07:40:05 -0700 (PDT) In-Reply-To: <1304069186-3086-2-git-send-email-j-pihet@ti.com> (jean pihet's message of "Fri, 29 Apr 2011 11:26:22 +0200") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: jean.pihet@newoldbits.com Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Tony Lindgren , Jean Pihet jean.pihet@newoldbits.com writes: > From: Jean Pihet > > The cpuidle states settings can be overriden by some board- > specific settings, by calling omap3_pm_init_cpuidle. > Remove the 3430SDP specific states settings registration > since the figures are identical to the default ones (in cpuidle34xx.c). > > Signed-off-by: Jean Pihet Thanks, queuing for 2.6.40 (branch: for_2.6.40/pm-cleanup) Kevin > --- > arch/arm/mach-omap2/board-3430sdp.c | 19 ------------------- > 1 files changed, 0 insertions(+), 19 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-3430sdp.c b/arch/arm/mach-omap2/board-3430sdp.c > index 9afd087..7ffad7b 100644 > --- a/arch/arm/mach-omap2/board-3430sdp.c > +++ b/arch/arm/mach-omap2/board-3430sdp.c > @@ -59,24 +59,6 @@ > > #define TWL4030_MSECURE_GPIO 22 > > -/* FIXME: These values need to be updated based on more profiling on 3430sdp*/ > -static struct cpuidle_params omap3_cpuidle_params_table[] = { > - /* C1 */ > - {1, 2, 2, 5}, > - /* C2 */ > - {1, 10, 10, 30}, > - /* C3 */ > - {1, 50, 50, 300}, > - /* C4 */ > - {1, 1500, 1800, 4000}, > - /* C5 */ > - {1, 2500, 7500, 12000}, > - /* C6 */ > - {1, 3000, 8500, 15000}, > - /* C7 */ > - {1, 10000, 30000, 300000}, > -}; > - > static uint32_t board_keymap[] = { > KEY(0, 0, KEY_LEFT), > KEY(0, 1, KEY_RIGHT), > @@ -883,7 +865,6 @@ static void __init omap_3430sdp_init(void) > omap3_mux_init(board_mux, OMAP_PACKAGE_CBB); > omap_board_config = sdp3430_config; > omap_board_config_size = ARRAY_SIZE(sdp3430_config); > - omap3_pm_init_cpuidle(omap3_cpuidle_params_table); > omap3430_i2c_init(); > omap_display_init(&sdp3430_dss_data); > if (omap_rev() > OMAP3430_REV_ES1_0)