Re: [PATCH 0/3] OMAP4: DSS OMAP4 hwmod support

[Kevin Hilman <khilman@ti.com>]

Hi Sumit,

"Semwal, Sumit" <sumit.semwal@ti.com> writes:

> On Sat, Jan 8, 2011 at 4:32 AM, Kevin Hilman <khilman@ti.com> wrote:
>> Sumit Semwal <sumit.semwal@ti.com> writes:
>>
>>> This patch series enables support for OMAP4 DSS, and adds hwmod support
>>> for dss, dispc, dsi1, dsi2, hdmi, rfbi and venc hwmods.
>>
>> This series is confusing as the 3 patches here do not do all the things
>> described here.
>>
>> It also doesn't apply to the master branch (e.g. PATCH 3/3 modifies
>> display.c, which doesn't exist until your other series.)
>
> First up, apologies for submitting these patches while the dependent
> patch series is still under discussion - I guess I should've waited
> till the hwmod patch series is accepted, but I thought mentioning the
> dependency might be sufficient. will take care in future.

No, stating the dependency in the changelog/cover letter is sufficient.

This is my fault for not fully parsing your description of the
dependencies and trying to apply directly to linux-omap.  My apologies.

Sorry for the noise,

Kevin

> Though I don't quite understand why you think that the 3 patches don't
> do all that is described.
>
> The first patch enables building DSS for OMAP4 by updating the Kconfig
> accordingly.
> The second patch enables hwmod support for all the dss IP hwmod
> devices, and the third one enhances the hwmod lookup to lookup OMAP4
> devices as well.
>
> If you could tell me what is missing or extra, I would correct that
> and send an updated version.
>
> Thanks, and best regards,
> ~Sumit.
>>
>> Please take care when writing these cover letters to be sure they are
>> accurate, otherwise reviewers/maintainers can't help but be confused
>> about what is going on.
>>
>> Kevin
>>
>>
>>> In OMAP4 there are severals IPs that can be reached by differents
>>> interconnect paths depending of the access initiator (MPU vs. SDMA).
>>>
>>> In the case of the DSS, both L3 direct path and L4 CFG path can be
>>> used to access all the DSS IPs.
>>> dss is also considered as an IP as dispc, rfbi, and named as dss_dss.
>>>
>>> TODO:
>>> This patch doesn't handle the opt clocks via hwmod - there will be a separate
>>> patch series which will take opt clock roles from hwmod, populate them in
>>> the device structure, so that the driver can ask for relevant opt-clocks.
>>>
>>> Also TBD is the migration to pm_runtime APIs, which need to be adapted a little
>>> for handling DSS-family of clocks completely.
>>>
>>> Patch Base:
>>> ===========
>>> url = git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git
>>> branch "master"
>>> Commit id: fa3b4e23ec20cfc944db7cc2b30b0d82c20e4472
>>> Description:  cbus: Fix retu_rtc_do_reset
>>> +
>>> hwmod patches under discussion: http://www.mail-archive.com/linux-omap@vger.kernel.org/msg41534.html
>>> +
>>> patch series: OMAP2PLUS: DSS: Generalize clock names
>>> --------------------------------------------------------
>>>
>>> Benoit Cousson (1):
>>>   OMAP4: hwmod data: add DSS DISPC DSI1,2 RFBI HDMI VENC
>>>
>>> Mayuresh Janorkar (1):
>>>   OMAP2PLUS: DSS2: Add OMAP4 support
>>>
>>> Sumit Semwal (1):
>>>   OMAP4: DSS2: Add hwmod device names for OMAP4.
>>>
>>>  arch/arm/mach-omap2/display.c              |   23 +-
>>>  arch/arm/mach-omap2/omap_hwmod_44xx_data.c |  588 ++++++++++++++++++++++++++++
>>>  drivers/video/omap2/dss/Kconfig            |    6 +-
>>>  drivers/video/omap2/omapfb/Kconfig         |    6 +-
>>>  4 files changed, 609 insertions(+), 14 deletions(-)
>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html