From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 0/3] OMAP4: DSS OMAP4 hwmod support Date: Mon, 10 Jan 2011 17:36:11 -0800 Message-ID: <87oc7ofchg.fsf@ti.com> References: <1294249444-11951-1-git-send-email-sumit.semwal@ti.com> <87wrmgjp1e.fsf@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from na3sys009aog110.obsmtp.com ([74.125.149.203]:43852 "EHLO na3sys009aog110.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752391Ab1AKBgP convert rfc822-to-8bit (ORCPT ); Mon, 10 Jan 2011 20:36:15 -0500 Received: by mail-iy0-f172.google.com with SMTP id 42so18818264iyi.3 for ; Mon, 10 Jan 2011 17:36:14 -0800 (PST) In-Reply-To: (Sumit Semwal's message of "Sun, 9 Jan 2011 14:19:46 +0530") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Semwal, Sumit" Cc: tomi.valkeinen@nokia.com, paul@pwsan.com, hvaibhav@ti.com, linux-omap@vger.kernel.org Hi Sumit, "Semwal, Sumit" writes: > On Sat, Jan 8, 2011 at 4:32 AM, Kevin Hilman wrote: >> Sumit Semwal writes: >> >>> This patch series enables support for OMAP4 DSS, and adds hwmod sup= port >>> for dss, dispc, dsi1, dsi2, hdmi, rfbi and venc hwmods. >> >> This series is confusing as the 3 patches here do not do all the thi= ngs >> described here. >> >> It also doesn't apply to the master branch (e.g. PATCH 3/3 modifies >> display.c, which doesn't exist until your other series.) > > First up, apologies for submitting these patches while the dependent > patch series is still under discussion - I guess I should've waited > till the hwmod patch series is accepted, but I thought mentioning the > dependency might be sufficient. will take care in future. No, stating the dependency in the changelog/cover letter is sufficient. This is my fault for not fully parsing your description of the dependencies and trying to apply directly to linux-omap. My apologies. Sorry for the noise, Kevin > Though I don't quite understand why you think that the 3 patches don'= t > do all that is described. > > The first patch enables building DSS for OMAP4 by updating the Kconfi= g > accordingly. > The second patch enables hwmod support for all the dss IP hwmod > devices, and the third one enhances the hwmod lookup to lookup OMAP4 > devices as well. > > If you could tell me what is missing or extra, I would correct that > and send an updated version. > > Thanks, and best regards, > ~Sumit. >> >> Please take care when writing these cover letters to be sure they ar= e >> accurate, otherwise reviewers/maintainers can't help but be confused >> about what is going on. >> >> Kevin >> >> >>> In OMAP4 there are severals IPs that can be reached by differents >>> interconnect paths depending of the access initiator (MPU vs. SDMA)= =2E >>> >>> In the case of the DSS, both L3 direct path and L4 CFG path can be >>> used to access all the DSS IPs. >>> dss is also considered as an IP as dispc, rfbi, and named as dss_ds= s. >>> >>> TODO: >>> This patch doesn't handle the opt clocks via hwmod - there will be = a separate >>> patch series which will take opt clock roles from hwmod, populate t= hem in >>> the device structure, so that the driver can ask for relevant opt-c= locks. >>> >>> Also TBD is the migration to pm_runtime APIs, which need to be adap= ted a little >>> for handling DSS-family of clocks completely. >>> >>> Patch Base: >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>> url =3D git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-= omap-2.6.git >>> branch "master" >>> Commit id: fa3b4e23ec20cfc944db7cc2b30b0d82c20e4472 >>> Description: =C2=A0cbus: Fix retu_rtc_do_reset >>> + >>> hwmod patches under discussion: http://www.mail-archive.com/linux-o= map@vger.kernel.org/msg41534.html >>> + >>> patch series: OMAP2PLUS: DSS: Generalize clock names >>> -------------------------------------------------------- >>> >>> Benoit Cousson (1): >>> =C2=A0 OMAP4: hwmod data: add DSS DISPC DSI1,2 RFBI HDMI VENC >>> >>> Mayuresh Janorkar (1): >>> =C2=A0 OMAP2PLUS: DSS2: Add OMAP4 support >>> >>> Sumit Semwal (1): >>> =C2=A0 OMAP4: DSS2: Add hwmod device names for OMAP4. >>> >>> =C2=A0arch/arm/mach-omap2/display.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0| =C2=A0 23 +- >>> =C2=A0arch/arm/mach-omap2/omap_hwmod_44xx_data.c | =C2=A0588 ++++++= ++++++++++++++++++++++ >>> =C2=A0drivers/video/omap2/dss/Kconfig =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0| =C2=A0 =C2=A06 +- >>> =C2=A0drivers/video/omap2/omapfb/Kconfig =C2=A0 =C2=A0 =C2=A0 =C2=A0= | =C2=A0 =C2=A06 +- >>> =C2=A04 files changed, 609 insertions(+), 14 deletions(-) >>> >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-oma= p" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at =C2=A0http://vger.kernel.org/majordomo-info.= html >> -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html