From: Kevin Hilman <khilman@deeprootsystems.com>
To: Vishwanath BS <vishwanath.bs@ti.com>
Cc: linux-omap@vger.kernel.org, Partha Basak <p-basak2@ti.com>
Subject: Re: [PATCH] I2C: Fix for suspend/resume issue in i2c-core
Date: Wed, 01 Sep 2010 08:53:02 -0700 [thread overview]
Message-ID: <87occhlau9.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1283219414-8798-1-git-send-email-vishwanath.bs@ti.com> (Vishwanath BS's message of "Tue, 31 Aug 2010 07:20:14 +0530")
[removed non-OMAP folks]
Vishwanath BS <vishwanath.bs@ti.com> writes:
> In current i2c core driver, pm_runtime_set_active call from i2c_device_pm_resume
> is not balanced by pm_runtime_set_suspended call from i2c_device_pm_suspend.
> pm_runtime_set_active called from resume path will increase the child_count of
> the device's parent. However, matching pm_runtime_set_suspended is not called
> in suspend routine because of which child_count of the device's parent
> is not balanced, preventing the parent device to idle.
> Issue has been fixed by adding pm_runtime_set_suspended call inside suspend
> reoutine which will make sure that child_counts are balanced.
> This fix has been tested on OMAP4430.
FYI... for OMAP folks. Now that this is queued for upstream, it will be
included in my pm-backports branch[1] and included in the PM branch until
it gets merged upstream.
Thanks Vishwa/Partha for getting this merged upstream.
Kevin
[1] for a description of the various branches that make up the PM
branch, please see 'What makes up the PM branch' section of the OMAP PM
wiki:
http://elinux.org/OMAP_Power_Management
prev parent reply other threads:[~2010-09-01 15:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-31 1:50 [PATCH] I2C: Fix for suspend/resume issue in i2c-core Vishwanath BS
[not found] ` <1283219414-8798-1-git-send-email-vishwanath.bs-l0cyMroinI0@public.gmane.org>
2010-08-30 18:43 ` Kevin Hilman
2010-08-31 11:16 ` Mark Brown
[not found] ` <20100831111611.GF20849-HF5t3jzXg/6ND3a5+9QAFujbO/Zr0HzV@public.gmane.org>
2010-08-31 23:12 ` Rafael J. Wysocki
[not found] ` <201009010112.11834.rjw-KKrjLPT3xs0@public.gmane.org>
2010-09-01 8:40 ` Jean Delvare
[not found] ` <20100901104052.5967ca25-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2010-09-03 17:38 ` Sripathy, Vishwanath
[not found] ` <FCCFB4CDC6E5564B9182F639FC35608703114DA108-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-09-03 23:10 ` Rafael J. Wysocki
[not found] ` <201009040110.10858.rjw-KKrjLPT3xs0@public.gmane.org>
2010-09-04 6:49 ` Jean Delvare
2010-09-01 15:53 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87occhlau9.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=p-basak2@ti.com \
--cc=vishwanath.bs@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).