public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@deeprootsystems.com>
To: Nishanth Menon <nm@ti.com>
Cc: Manjunatha GK <manjugk@ti.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v3] [OMAP3_PM] Fix zoom2/zoom3 build error
Date: Mon, 16 Nov 2009 09:31:23 -0800	[thread overview]
Message-ID: <87ocn2l6l0.fsf@deeprootsystems.com> (raw)
In-Reply-To: <4B016725.3030007@ti.com> (Nishanth Menon's message of "Mon\, 16 Nov 2009 08\:52\:21 -0600")

Nishanth Menon <nm@ti.com> writes:

> Manjunatha GK had written, on 11/16/2009 08:46 AM, the following:
> Thanks.
>>Re: [PATCH v3] [OMAP3_PM] Fix zoom2/zoom3 build error
> please rename subject to:
> [PATCH V3] OMAP3: PM: Fix build failure with !DEBUG_FS
>
> this is not zoom2/zoom3 specific - am I right?
>
>> The Zoom2 and Zoom3 build breaks on linux-omap-pm(HEAD:pm)
>> when CONFIG_DEBUG_FS is not enabled. 
>>
>> Build error log:
>> arch/arm/mach-omap2/built-in.o: In function `omap_sram_idle':
>> arch/arm/mach-omap2/pm34xx.c:449: undefined reference to `pm_dbg_regset_save'
>> arch/arm/mach-omap2/pm34xx.c:460: undefined reference to `pm_dbg_regset_save'
>> arch/arm/mach-omap2/built-in.o: In function `configure_vc':
>> arch/arm/mach-omap2/pm34xx.c:1237: undefined reference to `pm_dbg_regset_init'
>> arch/arm/mach-omap2/pm34xx.c:1238: undefined reference to `pm_dbg_regset_init'
>> make: *** [.tmp_vmlinux1] Error 1
>>
>> This patch fixes the above errors.
> you could state "provide entries for the same when the DEBUG_FS is
> undefined"
>

I agree with Nishanth's comments.

Since these are minor, I'll do cleanups to subject and changelog and
push this to the PM branch.

Thanks,

Kevin

      reply	other threads:[~2009-11-16 17:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-16 14:46 [PATCH v3] [OMAP3_PM] Fix zoom2/zoom3 build error Manjunatha GK
2009-11-16 14:52 ` Nishanth Menon
2009-11-16 17:31   ` Kevin Hilman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ocn2l6l0.fsf@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=manjugk@ti.com \
    --cc=nm@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox