[PATCH 1/1] ti-sysc: allow OMAP2 and OMAP4 timers to be reserved on AM33xx

[PATCH 1/1] ti-sysc: allow OMAP2 and OMAP4 timers to be reserved on AM33xx

[Alexander Stein]

From: Matthias Schiffer <matthias.schiffer@tq-group.com>

am33xx.dtsi has the same clock setup as am35xx.dtsi, setting
ti,no-reset-on-init and ti,no-idle on timer1_target and timer2_target,
so AM33 needs the same workaround as AM35 to avoid ti-sysc probe
failing on certain target modules.

Signed-off-by: Matthias Schiffer <matthias.schiffer@tq-group.com>
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 drivers/bus/ti-sysc.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
index 5566ad11399e7..610354ce7f8f0 100644
--- a/drivers/bus/ti-sysc.c
+++ b/drivers/bus/ti-sysc.c
@@ -48,6 +48,7 @@ enum sysc_soc {
 	SOC_UNKNOWN,
 	SOC_2420,
 	SOC_2430,
+	SOC_AM33,
 	SOC_3430,
 	SOC_AM35,
 	SOC_3630,
@@ -2912,6 +2913,7 @@ static void ti_sysc_idle(struct work_struct *work)
 static const struct soc_device_attribute sysc_soc_match[] = {
 	SOC_FLAG("OMAP242*", SOC_2420),
 	SOC_FLAG("OMAP243*", SOC_2430),
+	SOC_FLAG("AM33*", SOC_AM33),
 	SOC_FLAG("AM35*", SOC_AM35),
 	SOC_FLAG("OMAP3[45]*", SOC_3430),
 	SOC_FLAG("OMAP3[67]*", SOC_3630),
@@ -3117,10 +3119,15 @@ static int sysc_check_active_timer(struct sysc *ddata)
 	 * can be dropped if we stop supporting old beagleboard revisions
 	 * A to B4 at some point.
 	 */
-	if (sysc_soc->soc == SOC_3430 || sysc_soc->soc == SOC_AM35)
+	switch (sysc_soc->soc) {
+	case SOC_AM33:
+	case SOC_3430:
+	case SOC_AM35:
 		error = -ENXIO;
-	else
+		break;
+	default:
 		error = -EBUSY;
+	}
 
 	if ((ddata->cfg.quirks & SYSC_QUIRK_NO_RESET_ON_INIT) &&
 	    (ddata->cfg.quirks & SYSC_QUIRK_NO_IDLE))
-- 
2.43.0

Re: [PATCH 1/1] ti-sysc: allow OMAP2 and OMAP4 timers to be reserved on AM33xx

[Kevin Hilman]

On Mon, 25 Aug 2025 15:11:13 +0200, Alexander Stein wrote:
> am33xx.dtsi has the same clock setup as am35xx.dtsi, setting
> ti,no-reset-on-init and ti,no-idle on timer1_target and timer2_target,
> so AM33 needs the same workaround as AM35 to avoid ti-sysc probe
> failing on certain target modules.
> 
> 

Applied, thanks!

[1/1] ti-sysc: allow OMAP2 and OMAP4 timers to be reserved on AM33xx
      commit: 3f61783920504b2cf99330b372d82914bb004d8e

Best regards,
-- 
Kevin Hilman <khilman@baylibre.com>

Re: [PATCH 1/1] ti-sysc: allow OMAP2 and OMAP4 timers to be reserved on AM33xx

[Mathieu Othacehe]

Hello,

> am33xx.dtsi has the same clock setup as am35xx.dtsi, setting
> ti,no-reset-on-init and ti,no-idle on timer1_target and timer2_target,
> so AM33 needs the same workaround as AM35 to avoid ti-sysc probe
> failing on certain target modules.

On am335 (Linux 6.12.66), this commit has solved those two errors:

[ 0.882765] ti-sysc: probe of 44e31000.target-module failed with error -16
[ 0.973457] ti-sysc: probe of 48040000.target-module failed with error -16

but has in turn introduced those two:

[ 2.149708] ti-sysc 44e31000.target-module: Failed to create device link (0x180) with ocp
[ 2.149735] ti-sysc 48040000.target-module: Failed to create device link (0x180) with ocp

Any idea how to fix those?

Thanks,

Mathieu