From: Kevin Hilman <khilman@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] gpio/omap: Fix section warning for omap_mpuio_alloc_gc()
Date: Tue, 06 Mar 2012 15:55:47 -0800 [thread overview]
Message-ID: <87pqcpb7y4.fsf@ti.com> (raw)
In-Reply-To: <20120306212605.GY12083@atomide.com> (Tony Lindgren's message of "Tue, 6 Mar 2012 13:26:06 -0800")
Tony Lindgren <tony@atomide.com> writes:
> From: Tony Lindgren <tony@atomide.com>
> Date: Mon, 5 Mar 2012 15:32:38 -0800
> Subject: [PATCH] gpio/omap: Fix section warning for omap_mpuio_alloc_gc()
>
> Make omap_mpuio_alloc_gc() __devinit as omap_gpio_chip_init()
> is __devinit. Otherwise we get:
>
> WARNING: vmlinux.o(.devinit.text+0xa10): Section mismatch in reference
> from the function omap_gpio_chip_init() to the function .init.text:omap_mpuio_alloc_gc()
> The function __devinit omap_gpio_chip_init() references
> a function __init omap_mpuio_alloc_gc().
> If omap_mpuio_alloc_gc is only used by omap_gpio_chip_init then
> annotate omap_mpuio_alloc_gc with a matching annotation.
>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Acked-by: Kevin Hilman <khilman@ti.com>
> --- a/drivers/gpio/gpio-omap.c
> +++ b/drivers/gpio/gpio-omap.c
> @@ -1081,7 +1081,7 @@ static void omap_gpio_mod_init(struct gpio_bank *bank, int id)
> }
> }
>
> -static __init void
> +static __devinit void
> omap_mpuio_alloc_gc(struct gpio_bank *bank, unsigned int irq_start,
> unsigned int num)
> {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-03-06 23:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 21:26 [PATCH] gpio/omap: Fix section warning for omap_mpuio_alloc_gc() Tony Lindgren
2012-03-06 23:55 ` Kevin Hilman [this message]
2012-03-12 17:45 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pqcpb7y4.fsf@ti.com \
--to=khilman@ti.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox