From: Kevin Hilman <khilman@ti.com>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: linux-omap@vger.kernel.org, paul@pwsan.com, b-cousson@ti.com,
rnayak@ti.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/6] omap4: powerdomain: Add supported INACTIVE power state
Date: Tue, 01 Feb 2011 17:19:10 -0800 [thread overview]
Message-ID: <87pqrbmdwx.fsf@ti.com> (raw)
In-Reply-To: <1296212688-21951-2-git-send-email-santosh.shilimkar@ti.com> (Santosh Shilimkar's message of "Fri, 28 Jan 2011 16:34:43 +0530")
Santosh Shilimkar <santosh.shilimkar@ti.com> writes:
> On OMAP4, one can explicitly program INACTIVE as the power state of
> the logic area inside the power domain. Techincally PD state programmed
> to ON and if all the clock domains within the PD are idled, is equivalent
> tp PD programmed to INACTIVE and all the clock domains within the PD are
> idled. There won't be any power difference in above two.
>
> Since the CPUIDLE C-states explicitly make use of INACTIVE as a PD
> targeted state
I think you're referring to code that is not upstream here. I'm not
aware of any C-states targetting INACTIVE.
Kevin
> and also there is some additional latancy involved
> with PD INACTIVE vs PD ON, it's better to support it as an explcit
> PD state.
>
> This patch adds the support to allow explicit PD INACTIVE
> programming if supported.
>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Cc: Paul Walmsley <paul@pwsan.com>
> ---
> arch/arm/mach-omap2/powerdomain.h | 12 ++++++++++++
> arch/arm/mach-omap2/powerdomains44xx_data.c | 26 +++++++++++++-------------
> 2 files changed, 25 insertions(+), 13 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/powerdomain.h b/arch/arm/mach-omap2/powerdomain.h
> index c66431e..0e15ca7 100644
> --- a/arch/arm/mach-omap2/powerdomain.h
> +++ b/arch/arm/mach-omap2/powerdomain.h
> @@ -46,6 +46,18 @@
>
> #define PWRSTS_OFF_RET_ON (PWRSTS_OFF_RET | (1 << PWRDM_POWER_ON))
>
> +#define PWRSTS_RET_INA_ON ((1 << PWRDM_POWER_RET) | \
> + (1 << PWRDM_POWER_INACTIVE) | \
> + (1 << PWRDM_POWER_ON))
> +
> +#define PWRSTS_OFF_INA_ON ((1 << PWRDM_POWER_OFF) | \
> + (1 << PWRDM_POWER_INACTIVE) | \
> + (1 << PWRDM_POWER_ON))
> +
> +#define PWRSTS_OFF_RET_INA_ON ((1 << PWRDM_POWER_OFF) | \
> + (1 << PWRDM_POWER_RET) | \
> + (1 << PWRDM_POWER_INACTIVE) | \
> + (1 << PWRDM_POWER_ON))
>
> /* Powerdomain flags */
> #define PWRDM_HAS_HDWR_SAR (1 << 0) /* hardware save-and-restore support */
> diff --git a/arch/arm/mach-omap2/powerdomains44xx_data.c b/arch/arm/mach-omap2/powerdomains44xx_data.c
> index 26d7641..96cde98 100644
> --- a/arch/arm/mach-omap2/powerdomains44xx_data.c
> +++ b/arch/arm/mach-omap2/powerdomains44xx_data.c
> @@ -36,7 +36,7 @@ static struct powerdomain core_44xx_pwrdm = {
> .prcm_offs = OMAP4430_PRM_CORE_INST,
> .prcm_partition = OMAP4430_PRM_PARTITION,
> .omap_chip = OMAP_CHIP_INIT(CHIP_IS_OMAP4430),
> - .pwrsts = PWRSTS_RET_ON,
> + .pwrsts = PWRSTS_RET_INA_ON,
> .pwrsts_logic_ret = PWRSTS_OFF_RET,
> .banks = 5,
> .pwrsts_mem_ret = {
> @@ -62,7 +62,7 @@ static struct powerdomain gfx_44xx_pwrdm = {
> .prcm_offs = OMAP4430_PRM_GFX_INST,
> .prcm_partition = OMAP4430_PRM_PARTITION,
> .omap_chip = OMAP_CHIP_INIT(CHIP_IS_OMAP4430),
> - .pwrsts = PWRSTS_OFF_ON,
> + .pwrsts = PWRSTS_OFF_INA_ON,
> .banks = 1,
> .pwrsts_mem_ret = {
> [0] = PWRDM_POWER_OFF, /* gfx_mem */
> @@ -79,7 +79,7 @@ static struct powerdomain abe_44xx_pwrdm = {
> .prcm_offs = OMAP4430_PRM_ABE_INST,
> .prcm_partition = OMAP4430_PRM_PARTITION,
> .omap_chip = OMAP_CHIP_INIT(CHIP_IS_OMAP4430),
> - .pwrsts = PWRSTS_OFF_RET_ON,
> + .pwrsts = PWRSTS_OFF_RET_INA_ON,
> .pwrsts_logic_ret = PWRDM_POWER_OFF,
> .banks = 2,
> .pwrsts_mem_ret = {
> @@ -99,7 +99,7 @@ static struct powerdomain dss_44xx_pwrdm = {
> .prcm_offs = OMAP4430_PRM_DSS_INST,
> .prcm_partition = OMAP4430_PRM_PARTITION,
> .omap_chip = OMAP_CHIP_INIT(CHIP_IS_OMAP4430),
> - .pwrsts = PWRSTS_OFF_RET_ON,
> + .pwrsts = PWRSTS_OFF_RET_INA_ON,
> .pwrsts_logic_ret = PWRSTS_OFF,
> .banks = 1,
> .pwrsts_mem_ret = {
> @@ -117,7 +117,7 @@ static struct powerdomain tesla_44xx_pwrdm = {
> .prcm_offs = OMAP4430_PRM_TESLA_INST,
> .prcm_partition = OMAP4430_PRM_PARTITION,
> .omap_chip = OMAP_CHIP_INIT(CHIP_IS_OMAP4430),
> - .pwrsts = PWRSTS_OFF_RET_ON,
> + .pwrsts = PWRSTS_OFF_RET_INA_ON,
> .pwrsts_logic_ret = PWRSTS_OFF_RET,
> .banks = 3,
> .pwrsts_mem_ret = {
> @@ -155,7 +155,7 @@ static struct powerdomain cpu0_44xx_pwrdm = {
> .prcm_offs = OMAP4430_PRCM_MPU_CPU0_INST,
> .prcm_partition = OMAP4430_PRCM_MPU_PARTITION,
> .omap_chip = OMAP_CHIP_INIT(CHIP_IS_OMAP4430),
> - .pwrsts = PWRSTS_OFF_RET_ON,
> + .pwrsts = PWRSTS_OFF_RET_INA_ON,
> .pwrsts_logic_ret = PWRSTS_OFF_RET,
> .banks = 1,
> .pwrsts_mem_ret = {
> @@ -172,7 +172,7 @@ static struct powerdomain cpu1_44xx_pwrdm = {
> .prcm_offs = OMAP4430_PRCM_MPU_CPU1_INST,
> .prcm_partition = OMAP4430_PRCM_MPU_PARTITION,
> .omap_chip = OMAP_CHIP_INIT(CHIP_IS_OMAP4430),
> - .pwrsts = PWRSTS_OFF_RET_ON,
> + .pwrsts = PWRSTS_OFF_RET_INA_ON,
> .pwrsts_logic_ret = PWRSTS_OFF_RET,
> .banks = 1,
> .pwrsts_mem_ret = {
> @@ -205,7 +205,7 @@ static struct powerdomain mpu_44xx_pwrdm = {
> .prcm_offs = OMAP4430_PRM_MPU_INST,
> .prcm_partition = OMAP4430_PRM_PARTITION,
> .omap_chip = OMAP_CHIP_INIT(CHIP_IS_OMAP4430),
> - .pwrsts = PWRSTS_OFF_RET_ON,
> + .pwrsts = PWRSTS_OFF_RET_INA_ON,
> .pwrsts_logic_ret = PWRSTS_OFF_RET,
> .banks = 3,
> .pwrsts_mem_ret = {
> @@ -226,7 +226,7 @@ static struct powerdomain ivahd_44xx_pwrdm = {
> .prcm_offs = OMAP4430_PRM_IVAHD_INST,
> .prcm_partition = OMAP4430_PRM_PARTITION,
> .omap_chip = OMAP_CHIP_INIT(CHIP_IS_OMAP4430),
> - .pwrsts = PWRSTS_OFF_RET_ON,
> + .pwrsts = PWRSTS_OFF_RET_INA_ON,
> .pwrsts_logic_ret = PWRDM_POWER_OFF,
> .banks = 4,
> .pwrsts_mem_ret = {
> @@ -250,7 +250,7 @@ static struct powerdomain cam_44xx_pwrdm = {
> .prcm_offs = OMAP4430_PRM_CAM_INST,
> .prcm_partition = OMAP4430_PRM_PARTITION,
> .omap_chip = OMAP_CHIP_INIT(CHIP_IS_OMAP4430),
> - .pwrsts = PWRSTS_OFF_ON,
> + .pwrsts = PWRSTS_OFF_INA_ON,
> .banks = 1,
> .pwrsts_mem_ret = {
> [0] = PWRDM_POWER_OFF, /* cam_mem */
> @@ -267,7 +267,7 @@ static struct powerdomain l3init_44xx_pwrdm = {
> .prcm_offs = OMAP4430_PRM_L3INIT_INST,
> .prcm_partition = OMAP4430_PRM_PARTITION,
> .omap_chip = OMAP_CHIP_INIT(CHIP_IS_OMAP4430),
> - .pwrsts = PWRSTS_RET_ON,
> + .pwrsts = PWRSTS_OFF_RET_INA_ON,
> .pwrsts_logic_ret = PWRSTS_OFF_RET,
> .banks = 1,
> .pwrsts_mem_ret = {
> @@ -285,7 +285,7 @@ static struct powerdomain l4per_44xx_pwrdm = {
> .prcm_offs = OMAP4430_PRM_L4PER_INST,
> .prcm_partition = OMAP4430_PRM_PARTITION,
> .omap_chip = OMAP_CHIP_INIT(CHIP_IS_OMAP4430),
> - .pwrsts = PWRSTS_RET_ON,
> + .pwrsts = PWRSTS_RET_INA_ON,
> .pwrsts_logic_ret = PWRSTS_OFF_RET,
> .banks = 2,
> .pwrsts_mem_ret = {
> @@ -317,7 +317,7 @@ static struct powerdomain cefuse_44xx_pwrdm = {
> .prcm_offs = OMAP4430_PRM_CEFUSE_INST,
> .prcm_partition = OMAP4430_PRM_PARTITION,
> .omap_chip = OMAP_CHIP_INIT(CHIP_IS_OMAP4430),
> - .pwrsts = PWRSTS_OFF_ON,
> + .pwrsts = PWRSTS_OFF_INA_ON,
> };
>
> /*
next prev parent reply other threads:[~2011-02-02 1:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-28 11:04 [PATCH 0/6] omap4: prcm: Few dpll, clockdomain and powerdomain updates Santosh Shilimkar
2011-01-28 11:04 ` [PATCH 1/6] omap4: powerdomain: Add supported INACTIVE power state Santosh Shilimkar
2011-01-31 23:14 ` Paul Walmsley
2011-02-01 6:29 ` Santosh Shilimkar
2011-02-01 12:39 ` Cousson, Benoit
2011-02-02 21:40 ` Paul Walmsley
2011-02-03 8:55 ` Santosh Shilimkar
2011-02-02 1:19 ` Kevin Hilman [this message]
2011-02-02 4:19 ` Rajendra Nayak
2011-02-02 21:28 ` Kevin Hilman
2011-02-03 9:00 ` Santosh Shilimkar
2011-01-28 11:04 ` [PATCH 2/6] omap4: prcm: Fix the CPUx clockdomain offsets Santosh Shilimkar
2011-02-02 1:20 ` Kevin Hilman
2011-02-02 9:24 ` Cousson, Benoit
2011-02-03 12:51 ` Cousson, Benoit
2011-01-28 11:04 ` [PATCH 3/6] omap4: powerdomain: Use intended PWRSTS_* flags instead of values Santosh Shilimkar
2011-02-02 1:21 ` Kevin Hilman
2011-02-02 6:15 ` Santosh Shilimkar
2011-01-28 11:04 ` [PATCH 4/6] omap4: dpll: Enable all DPLL autoidle at boot Santosh Shilimkar
2011-01-31 23:17 ` Paul Walmsley
2011-02-01 5:24 ` Rajendra Nayak
2011-01-28 11:04 ` [PATCH 5/6] omap4: dpll: Add dpll api to control GATE_CTRL Santosh Shilimkar
2011-01-28 11:04 ` [PATCH 6/6] omap4: dpll: Enable auto gate control for all MX postdividers Santosh Shilimkar
2011-01-28 12:37 ` [PATCH 0/6] omap4: prcm: Few dpll, clockdomain and powerdomain updates Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pqrbmdwx.fsf@ti.com \
--to=khilman@ti.com \
--cc=b-cousson@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox