From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver. Date: Fri, 03 Sep 2010 11:00:31 -0700 Message-ID: <87pqwu1zcw.fsf@deeprootsystems.com> References: <1282130412-12027-1-git-send-email-thara@ti.com> <1282130412-12027-2-git-send-email-thara@ti.com> <87eiddgjr7.fsf@deeprootsystems.com> <5A47E75E594F054BAF48C5E4FC4B92AB03291AD889@dbde02.ent.ti.com> <87r5ha3hlk.fsf@deeprootsystems.com> <20100903173046.GA32226@rakim.wolfsonmicro.main> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-qy0-f174.google.com ([209.85.216.174]:56795 "EHLO mail-qy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756909Ab0ICSAf (ORCPT ); Fri, 3 Sep 2010 14:00:35 -0400 Received: by qyk36 with SMTP id 36so242408qyk.19 for ; Fri, 03 Sep 2010 11:00:35 -0700 (PDT) In-Reply-To: <20100903173046.GA32226@rakim.wolfsonmicro.main> (Mark Brown's message of "Fri, 3 Sep 2010 18:30:47 +0100") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Mark Brown Cc: "Gopinath, Thara" , "linux-omap@vger.kernel.org" , "paul@pwsan.com" , "Sripathy, Vishwanath" , "Sawant, Anand" , "Cousson, Benoit" , "thomas.petazzoni@free-electrons.com" , Liam Girdwood Mark Brown writes: > On Fri, Sep 03, 2010 at 09:41:11AM -0700, Kevin Hilman wrote: > >> Like you, I'm no expert on the regulator framework internals, but it >> appears to have a pretty thorough system of constraints management that >> upon first glance seems to be a good fit for what we need. It may need >> to be extended, but I would rather see us enhance the regulator >> framework than re-invent the constraints management. > > This seems reasonable, the only thing I'm wary of with this stuff is > adding things to manage anything outside voltages since I'm not > convinced that the requirements of different processors for other things > are sufficiently well understood to make a simple abstraction. Mark, thanks for your input. For now, at least on OMAP, we're only thinking of managing voltages for the primary voltage rails on chip. We already have well defined layers for managing our power domains and clockdomains and prefer to keep that as OMAP-internal code, as it's nothing that drivers really need to be aware of. > The only thing I can think you might need to do if this is just straight > voltage setting is re-add support for multiple consumers setting > voltages simultaneously Yeah, that sounds like what we need. re-add? was it there at one point and removed? Any pointers to the old code? > (there was someone from Qualcomm talking about > that as well but I didn't see any patches from him) but the API side is > all there and the core support ought to be relatively straightforward. OK, thanks for the feedback. Kevin