public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH PM-20081119] OMAP: PM: Check both, IOPAD and UART wakeup always
@ 2008-11-20  8:43 Jouni Hogander
  2008-11-20 17:41 ` Kevin Hilman
  0 siblings, 1 reply; 2+ messages in thread
From: Jouni Hogander @ 2008-11-20  8:43 UTC (permalink / raw)
  To: linux-omap

Uart RX might not always generate IOPAD wake-up. E.g. IOPAD is not
enabled or core was not in sleep state.

Signed-off-by: Jouni Hogander <jouni.hogander@nokia.com>
---
 arch/arm/mach-omap2/serial.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c
index 745ae5c..8d2f0b1 100644
--- a/arch/arm/mach-omap2/serial.c
+++ b/arch/arm/mach-omap2/serial.c
@@ -281,7 +281,7 @@ void omap_uart_resume_idle(int num)
 			}
 
 			/* Check for normal UART wakeup */
-			else if (__raw_readl(uart->wk_st) & uart->wk_mask)
+			if (__raw_readl(uart->wk_st) & uart->wk_mask)
 				omap_uart_block_sleep(uart);
 
 			return;
-- 
1.6.0.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH PM-20081119] OMAP: PM: Check both, IOPAD and UART wakeup always
  2008-11-20  8:43 [PATCH PM-20081119] OMAP: PM: Check both, IOPAD and UART wakeup always Jouni Hogander
@ 2008-11-20 17:41 ` Kevin Hilman
  0 siblings, 0 replies; 2+ messages in thread
From: Kevin Hilman @ 2008-11-20 17:41 UTC (permalink / raw)
  To: Jouni Hogander; +Cc: linux-omap

Jouni Hogander <jouni.hogander@nokia.com> writes:

> Uart RX might not always generate IOPAD wake-up. E.g. IOPAD is not
> enabled or core was not in sleep state.
>
> Signed-off-by: Jouni Hogander <jouni.hogander@nokia.com>

Thanks, applying to pm-20081119.

Kevin

>  arch/arm/mach-omap2/serial.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c
> index 745ae5c..8d2f0b1 100644
> --- a/arch/arm/mach-omap2/serial.c
> +++ b/arch/arm/mach-omap2/serial.c
> @@ -281,7 +281,7 @@ void omap_uart_resume_idle(int num)
>  			}
>  
>  			/* Check for normal UART wakeup */
> -			else if (__raw_readl(uart->wk_st) & uart->wk_mask)
> +			if (__raw_readl(uart->wk_st) & uart->wk_mask)
>  				omap_uart_block_sleep(uart);
>  
>  			return;
> -- 
> 1.6.0.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-11-20 17:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-20  8:43 [PATCH PM-20081119] OMAP: PM: Check both, IOPAD and UART wakeup always Jouni Hogander
2008-11-20 17:41 ` Kevin Hilman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox