From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [RFC/RFT/PATCH V3] gpio: omap: refresh patch "be more aggressive with pm_runtime" against v3.12-rc5 Date: Mon, 09 Dec 2013 08:03:21 -0800 Message-ID: <87r49m8112.fsf@linaro.org> References: <1385506004-14943-1-git-send-email-caesarxuchao@gmail.com> <1386477638-6331-1-git-send-email-caesarxuchao@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1386477638-6331-1-git-send-email-caesarxuchao@gmail.com> (Chao Xu's message of "Sat, 7 Dec 2013 22:40:38 -0600") Sender: linux-gpio-owner@vger.kernel.org To: Chao Xu Cc: linux-omap@vger.kernel.org, santosh.shilimkar@ti.com, linus.walleij@linaro.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, tony@atomide.com, balbi@ti.com, nm@ti.com List-Id: linux-omap@vger.kernel.org Chao Xu writes: > From: Felipe Balbi > > try to keep gpio block suspended as much as possible. > Tested with pandaboard and a sysfs exported gpio. > > Signed-off-by: Felipe Balbi > > [caesarxuchao@gmail.com : Refreshed against v3.12-rc5, and added > revision check to enable aggressive pm_runtime on OMAP4-only. Because > am33xx_gpio_sysc.idlemodes seems to be wrongly marked as > SIDLE_SMART_WKUP, which might cause missed interrupts with this patch. > Tested on Pandaboard rev A2.] > Signed-off-by: Chao Xu I have several problems with this patch. First, the changelog is missing a lot of information. In particular, nowhere is it described what problem is this patch addressing and how this patch addresses that problem. Second, I don't see any mention of off-mode, and I suspect there are issues with off-mode here that are not being addressed. Also, I *really* don't like any approach that is targetted at a single SoC. Kevin