* Re: [PATCH -next] PM / AVS: SmartReflex: remove redundant dev_err call in omap_sr_probe() [not found] <CAPgLHd_K37Uf420FRiEkiCZQiL9bAdiE2_qG4dp7WmQRaCnDqQ@mail.gmail.com> @ 2013-06-26 13:06 ` Nishanth Menon [not found] ` <877gh8nbpm.fsf@linaro.org> 0 siblings, 1 reply; 3+ messages in thread From: Nishanth Menon @ 2013-06-26 13:06 UTC (permalink / raw) To: Wei Yongjun Cc: anton, dwmw2, khilman, andrii.tseglytskyi, jean.pihet, tony, yongjun_wei, linux-kernel, linux-omap On 09:57-20130626, Wei Yongjun wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > --- > drivers/power/avs/smartreflex.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c > index db9973b..c26acfc 100644 > --- a/drivers/power/avs/smartreflex.c > +++ b/drivers/power/avs/smartreflex.c > @@ -871,10 +871,8 @@ static int __init omap_sr_probe(struct platform_device *pdev) > > mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > sr_info->base = devm_ioremap_resource(&pdev->dev, mem); > - if (IS_ERR(sr_info->base)) { > - dev_err(&pdev->dev, "%s: ioremap fail\n", __func__); > + if (IS_ERR(sr_info->base)) > return PTR_ERR(sr_info->base); > - } > > irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > > Acked-by: Nishanth Menon <nm@ti.com> -- Regards, Nishanth Menon ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <877gh8nbpm.fsf@linaro.org>]
* [PATCH RESEND] PM / AVS: SmartReflex: remove redundant dev_err call in omap_sr_probe() [not found] ` <877gh8nbpm.fsf@linaro.org> @ 2013-07-12 4:59 ` Wei Yongjun 2013-08-05 16:25 ` Kevin Hilman 0 siblings, 1 reply; 3+ messages in thread From: Wei Yongjun @ 2013-07-12 4:59 UTC (permalink / raw) To: khilman Cc: nm, anton, dwmw2, andrii.tseglytskyi, jean.pihet, tony, yongjun_wei, linux-kernel, linux-omap, linux-pm There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Acked-by: Nishanth Menon <nm@ti.com> --- cc to linux-pm with Nishanth Menon's ACK --- drivers/power/avs/smartreflex.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c index db9973b..c26acfc 100644 --- a/drivers/power/avs/smartreflex.c +++ b/drivers/power/avs/smartreflex.c @@ -871,10 +871,8 @@ static int __init omap_sr_probe(struct platform_device *pdev) mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); sr_info->base = devm_ioremap_resource(&pdev->dev, mem); - if (IS_ERR(sr_info->base)) { - dev_err(&pdev->dev, "%s: ioremap fail\n", __func__); + if (IS_ERR(sr_info->base)) return PTR_ERR(sr_info->base); - } irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0); ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] PM / AVS: SmartReflex: remove redundant dev_err call in omap_sr_probe() 2013-07-12 4:59 ` [PATCH RESEND] " Wei Yongjun @ 2013-08-05 16:25 ` Kevin Hilman 0 siblings, 0 replies; 3+ messages in thread From: Kevin Hilman @ 2013-08-05 16:25 UTC (permalink / raw) To: Wei Yongjun Cc: nm, anton, dwmw2, andrii.tseglytskyi, jean.pihet, tony, yongjun_wei, linux-kernel, linux-omap, linux-pm Wei Yongjun <weiyj.lk@gmail.com> writes: > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > Acked-by: Nishanth Menon <nm@ti.com> > --- > cc to linux-pm with Nishanth Menon's ACK Thanks, queued for v3.12. Kevin > --- > drivers/power/avs/smartreflex.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c > index db9973b..c26acfc 100644 > --- a/drivers/power/avs/smartreflex.c > +++ b/drivers/power/avs/smartreflex.c > @@ -871,10 +871,8 @@ static int __init omap_sr_probe(struct platform_device *pdev) > > mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > sr_info->base = devm_ioremap_resource(&pdev->dev, mem); > - if (IS_ERR(sr_info->base)) { > - dev_err(&pdev->dev, "%s: ioremap fail\n", __func__); > + if (IS_ERR(sr_info->base)) > return PTR_ERR(sr_info->base); > - } > > irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-05 16:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CAPgLHd_K37Uf420FRiEkiCZQiL9bAdiE2_qG4dp7WmQRaCnDqQ@mail.gmail.com>
2013-06-26 13:06 ` [PATCH -next] PM / AVS: SmartReflex: remove redundant dev_err call in omap_sr_probe() Nishanth Menon
[not found] ` <877gh8nbpm.fsf@linaro.org>
2013-07-12 4:59 ` [PATCH RESEND] " Wei Yongjun
2013-08-05 16:25 ` Kevin Hilman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).