From: Kevin Hilman <khilman@deeprootsystems.com>
To: "Poddar, Sourav" <sourav.poddar@ti.com>
Cc: balbi@ti.com, gregkh@linuxfoundation.org, alan@linux.intel.com,
tony@atomide.com, linux-omap@vger.kernel.org,
linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, santosh.shilimkar@ti.com
Subject: Re: [PATCH] serial: omap: Remove unnecessary checks from suspend/resume
Date: Wed, 19 Sep 2012 14:43:17 -0700 [thread overview]
Message-ID: <87r4pxelje.fsf@deeprootsystems.com> (raw)
In-Reply-To: <CAKdam56UKpc3icL7J7+Om=5Qk_P4ckWM+XY5E+GFvXieAAxjyA@mail.gmail.com> (Sourav Poddar's message of "Tue, 18 Sep 2012 17:14:15 +0530")
"Poddar, Sourav" <sourav.poddar@ti.com> writes:
> Hi Felipe,
>
> On Tue, Sep 18, 2012 at 5:04 PM, Felipe Balbi <balbi@ti.com> wrote:
>> On Tue, Sep 18, 2012 at 05:05:54PM +0530, Sourav Poddar wrote:
>>> Drop the check for "up" being valid on suspend/resume callbacks.
>>> It should be valid always. Get rid of the "pdata" check also as
>>> serial_omap_get_context_loss_count() checks for it.
>>>
>>> Tested on omap4 panda and 3630 based Beagle board.
>>
>> you need a blank line here. Other than that:
>>
>> Reviewed-by: Felipe Balbi <balbi@ti.com>
>>
>> ps: what kind of tests did you run, btw ?
>>
> Boot tested on Panda.
> Boot and PM tested(hitiing Off) on Beagle.
What does "PM tested" mean. hitting off in idle? hitting off in
suspend? both?
Please clarify.
Thanks,
Kevin
next prev parent reply other threads:[~2012-09-19 21:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 11:35 [PATCH] serial: omap: Remove unnecessary checks from suspend/resume Sourav Poddar
2012-09-18 11:34 ` Felipe Balbi
2012-09-18 11:44 ` Poddar, Sourav
2012-09-19 21:43 ` Kevin Hilman [this message]
2012-09-21 5:10 ` Poddar, Sourav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4pxelje.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=alan@linux.intel.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=sourav.poddar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox