linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: Johan Hovold <jhovold@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>, linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/3] OMAP2+: pm: fix typos
Date: Mon, 29 Aug 2011 14:13:59 -0700	[thread overview]
Message-ID: <87r543rkdk.fsf@ti.com> (raw)
In-Reply-To: <1312907661-24436-1-git-send-email-jhovold@gmail.com> (Johan Hovold's message of "Tue, 9 Aug 2011 18:34:19 +0200")

Hi Johan,

Johan Hovold <jhovold@gmail.com> writes:

> Fix typos in comment and error message.
>
> Signed-off-by: Johan Hovold <jhovold@gmail.com>

Thanks for these PM-related cleanups.  They're much appreciated.

Patches 1 & 2 look fine.  However, can you please repost with the
linux-arm-kernel mailing list in Cc?    All patches for upstream should
also Cc that list: linux-arm-kernel@lists.infradead.org

Kevin

> ---
>  arch/arm/mach-omap2/pm.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c
> index 3feb359..fd77cf4 100644
> --- a/arch/arm/mach-omap2/pm.c
> +++ b/arch/arm/mach-omap2/pm.c
> @@ -163,11 +163,11 @@ err:
>  }
>  
>  /*
> - * This API is to be called during init to put the various voltage
> + * This API is to be called during init to set the various voltage
>   * domains to the voltage as per the opp table. Typically we boot up
>   * at the nominal voltage. So this function finds out the rate of
>   * the clock associated with the voltage domain, finds out the correct
> - * opp entry and puts the voltage domain to the voltage specifies
> + * opp entry and sets the voltage domain to the voltage specified
>   * in the opp entry
>   */
>  static int __init omap2_set_init_voltage(char *vdd_name, char *clk_name,
> @@ -218,7 +218,7 @@ static int __init omap2_set_init_voltage(char *vdd_name, char *clk_name,
>  	return 0;
>  
>  exit:
> -	printk(KERN_ERR "%s: Unable to put vdd_%s to its init voltage\n\n",
> +	printk(KERN_ERR "%s: Unable to set vdd_%s to its init voltage\n\n",
>  		__func__, vdd_name);
>  	return -EINVAL;
>  }

  parent reply	other threads:[~2011-08-29 21:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-09 16:34 [PATCH 1/3] OMAP2+: pm: fix typos Johan Hovold
2011-08-09 16:34 ` [PATCH 2/3] OMAP2+: pm: clean up error messages Johan Hovold
2011-08-09 16:34 ` [PATCH 3/3] OMAP2+: voltage: " Johan Hovold
2011-08-29 21:15   ` Kevin Hilman
2011-08-30 16:52     ` Johan Hovold
2011-08-29 21:13 ` Kevin Hilman [this message]
2011-08-30 16:48   ` [PATCH 1/2 RESEND] OMAP2+: pm: fix typos Johan Hovold
2011-08-30 16:48     ` [PATCH 2/2 RESEND] OMAP2+: pm: clean up error messages Johan Hovold
2011-08-30 21:15       ` Kevin Hilman
2011-08-30 21:14     ` [PATCH 1/2 RESEND] OMAP2+: pm: fix typos Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r543rkdk.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=jhovold@gmail.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).