From: Kevin Hilman <khilman@ti.com>
To: Todd Poynor <toddpoynor@google.com>
Cc: Russell King <linux@arm.linux.org.uk>,
Tony Lindgren <tony@atomide.com>,
lkml <linux-kernel@vger.kernel.org>,
Colin Cross <ccross@android.com>,
l-o <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: omap4: gpio: fix setting IRQWAKEN bits
Date: Mon, 06 Jun 2011 15:32:29 -0700 [thread overview]
Message-ID: <87r576wpz6.fsf@ti.com> (raw)
In-Reply-To: <BANLkTingmUNvZO_szivRkmn7LRO4L5A+5Q@mail.gmail.com> (Colin Cross's message of "Sat, 4 Jun 2011 19:37:54 -0700")
Colin Cross <ccross@android.com> writes:
> On Sat, Jun 4, 2011 at 12:03 PM, Colin Cross <ccross@android.com> wrote:
>> Setting the IRQWAKEN bit was overwriting previous IRQWAKEN bits,
>> causing only the last bit set to take effect, resulting in lost
>> wakeups when the GPIO controller is in idle.
>>
>> Replace direct writes to IRQWAKEN with writes to SETWKUENA and
>> CLEARWKUEN.
>>
>> Signed-off-by: Colin Cross <ccross@android.com>
[...]
>
> Todd pointed out that the OMAP4 TRM says not to use SETWKUENA and
> CLEARWKUENA.
In my GPIO cleanups, I was wondering why the set/clear registers were
not used here. Todd, can you give the TRM version & reference for this?
I didn't find anything after a quick scan/search.
Thanks,
Kevin
next prev parent reply other threads:[~2011-06-06 22:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-04 19:03 [PATCH] ARM: omap4: gpio: fix setting IRQWAKEN bits Colin Cross
2011-06-05 2:37 ` Colin Cross
2011-06-06 22:32 ` Kevin Hilman [this message]
2011-06-06 23:05 ` Todd Poynor
2011-06-06 23:25 ` Kevin Hilman
2011-06-06 7:02 ` Santosh Shilimkar
2011-06-06 7:23 ` DebBarma, Tarun Kanti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r576wpz6.fsf@ti.com \
--to=khilman@ti.com \
--cc=ccross@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=toddpoynor@google.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox