From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCHv5] omap3: Add basic support for 720MHz part Date: Tue, 08 Feb 2011 16:57:23 -0800 Message-ID: <87r5bif2j0.fsf@ti.com> References: <1296126687-1846-1-git-send-email-premi@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aog107.obsmtp.com ([74.125.149.197]:42716 "EHLO na3sys009aog107.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755128Ab1BIA50 (ORCPT ); Tue, 8 Feb 2011 19:57:26 -0500 Received: by mail-pz0-f48.google.com with SMTP id 28so1436209pzk.35 for ; Tue, 08 Feb 2011 16:57:25 -0800 (PST) In-Reply-To: (Sanjeev Premi's message of "Thu, 3 Feb 2011 17:00:14 +0530") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Premi, Sanjeev" Cc: "linux-omap@vger.kernel.org" "Premi, Sanjeev" writes: >> >> This patch adds support for speed enhanced variant of OMAP35x >> processors. These parts allow ARM and IVA running at 720MHz >> and 520MHz respectively. >> >> These parts can be detected at runtime by reading contents of >> PRODID.SKUID[3:0] at 0x4830A20C [1]. >> >> This patch specifically does following: >> * Add new OPP to omap34xx_opp_def_list[] - disabled by default. >> * Detect devices capable of running at new OPP. >> * Enable new OPP only if device supports it. >> * Check for presence of IVA before attempting to enable the >> corresponding OPP. >> >> [1] http://focus.ti.com/lit/ug/spruff1d/spruff1d.pdf >> >> It appears from discussions (on this patch) that a variant of >> OMAP3430 supports this OPP but lacks runtime detection. This >> OPP can be enabled for these device by either: >> 1) Setting the bit corresponding to OMAP3_HAS_720MHZ >> in 'omap3_features'. (Refer changes to id.c) >> 2) Removing check for omap3_has_720mhz() before enabling >> the OPP. (Refer changes to opp3xxx_data.c) >> 3) Calling opp_enable() for 720MHz/VDD1 and 520MHz/VDD2 in >> the board file. (Refer changes to opp3xxx_data.c). >> This should, ideally, be done before omap3_opp_init() is >> called during device_initcall(). >> >> CAUTION: This should be done for identified parts only. >> Else, the device could be damaged permanently. >> >> Signed-off-by: Sanjeev Premi >> Reviewed-by: G, Manjunath Kondaiah >> --- >> >> Since v4: >> Updated the commit text addressing comments from >> Kevin Hilman (khilman@ti.com). >> > > Kevin, > > Wanted to check if the decription addresses your comments. > Yes, very nice. Thanks. Kevin