From: Kevin Hilman <khilman@deeprootsystems.com>
To: "Datta, Shubhrajyoti" <shubhrajyoti@ti.com>
Cc: "Arce, Abraham" <x0066660@ti.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v6 8/8] Input: omap4 - pm runtime
Date: Wed, 08 Dec 2010 13:11:51 -0800 [thread overview]
Message-ID: <87r5dsezqg.fsf@deeprootsystems.com> (raw)
In-Reply-To: <0680EC522D0CC943BC586913CF3768C0041390E45B@dbde02.ent.ti.com> (Shubhrajyoti Datta's message of "Mon, 6 Dec 2010 18:30:00 +0530")
"Datta, Shubhrajyoti" <shubhrajyoti@ti.com> writes:
[...]
>> Subject: Re: [PATCH v6 8/8] Input: omap4 - pm runtime
>>
>> Abraham Arce <x0066660@ti.com> writes:
>>
>> > Enable pm runtime in driver
>>
>> So power is enabled on probe and cut on _remove(). Did you consider
>> doing any more fine grained PM for this device? For example, cutting
>> power after some inactivity timer and re-enabling on a
>> keypress/interrupt?
> My idea is that the clock needs to be on to get interrupts (OMAP4 the
> control is at module level and ick/fclk level control is
> difficult). So disabling will prevent interrupts. The keypad is in
> wakeup domain which is always on. So the power impact may be minimal.
>
> What do you think.
I think the changelog needs to be updated to describe the reasons behind
the decisions made.
Kevin
prev parent reply other threads:[~2010-12-08 21:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 5:36 [PATCH v6 8/8] Input: omap4 - pm runtime Abraham Arce
2010-09-30 13:51 ` Kevin Hilman
2010-10-01 5:31 ` Varadarajan, Charulatha
2010-12-06 13:00 ` Datta, Shubhrajyoti
2010-12-08 6:45 ` Basak, Partha
2010-12-08 21:11 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r5dsezqg.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=shubhrajyoti@ti.com \
--cc=x0066660@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox